Skip to content

Commit c22fd0e

Browse files
committed
fixing comments
1 parent a16aa37 commit c22fd0e

File tree

4 files changed

+5
-3
lines changed

4 files changed

+5
-3
lines changed

packages/sdk/browser/src/BrowserDataManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ export default class BrowserDataManager extends BaseDataManager {
212212
const pollingRequestor = makeRequestor(
213213
plainContextString,
214214
this.config.serviceEndpoints,
215-
this.getPollingPaths(), // note: this is the polling path because the requestor is only used to make polling requests.
215+
this.getPollingPaths(),
216216
this.platform.requests,
217217
this.platform.encoding!,
218218
this.baseHeaders,

packages/sdk/react-native/__tests__/MobileDataManager.test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,8 @@ describe('given a MobileDataManager with mocked dependencies', () => {
133133
return `/msdk/evalx/context`;
134134
},
135135
pathPing(_encoding: Encoding, _plainContextString: string): string {
136+
// Note: if you are seeing this error, it is a coding error. This DataSourcePaths implementation is for polling endpoints. /ping is not currently
137+
// used in a polling situation. It is probably the case that this was called by streaming logic erroneously.
136138
throw new Error('Ping for polling unsupported.');
137139
},
138140
}),

packages/sdk/react-native/src/MobileDataManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ export default class MobileDataManager extends BaseDataManager {
100100
const requestor = makeRequestor(
101101
plainContextString,
102102
this.config.serviceEndpoints,
103-
this.getPollingPaths(), // note: this is the polling path because the requestor is only used to make polling requests.
103+
this.getPollingPaths(),
104104
this.platform.requests,
105105
this.platform.encoding!,
106106
this.baseHeaders,

packages/shared/sdk-client/__tests__/TestDataManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ export default class TestDataManager extends BaseDataManager {
7979
const requestor = makeRequestor(
8080
JSON.stringify(Context.toLDContext(context)),
8181
this.config.serviceEndpoints,
82-
this.getPollingPaths(), // note: this is the polling path because the requestor is only used to make polling requests.
82+
this.getPollingPaths(),
8383
this.platform.requests,
8484
this.platform.encoding!,
8585
this.baseHeaders,

0 commit comments

Comments
 (0)