Merge remote-tracking branch 'origin/rlamb/fix-browser-contract-test-build' into rlamb/sdk-195/support-js-style-initialization

Author: kinyoklion

packages/sdk/browser/contract-tests/entity/package.json

@@ -5,7 +5,7 @@
   "type": "module",
   "description": "Contract test service implementation for @launchdarkly/js-client-sdk",
   "scripts": {
-    "start": "vite --open=true",
+    "start": "tsc --noEmit && vite --open=true",
     "build": "tsc --noEmit && vite build",
     "lint": "eslint ./src",
     "prettier": "prettier --write '**/*.@(js|ts|tsx|json|css)' --ignore-path ../../../../.prettierignore"

packages/sdk/browser/contract-tests/entity/src/ClientEntity.ts

@@ -65,6 +65,8 @@ function makeSdkConfig(options: SDKConfigParams, tag: string) {
     };
   }
 
+  cf.fetchGoals = false;
+
   return cf;
 }
 

packages/sdk/browser/src/BrowserClient.ts

@@ -19,6 +19,7 @@ import GoalManager from './goals/GoalManager';
 import { Goal, isClick } from './goals/Goals';
 import validateOptions, { BrowserOptions, filterToBaseOptions } from './options';
 import BrowserPlatform from './platform/BrowserPlatform';
+import { LDIdentifyOptions } from '@launchdarkly/js-client-sdk-common/dist/api/LDIdentifyOptions';
 
 /**
  * We are not supporting dynamically setting the connection mode on the LDClient.
@@ -206,8 +207,8 @@ export class BrowserClient extends LDClientImpl {
     };
   }
 
-  override async identify(context: LDContext): Promise<void> {
-    await super.identify(context);
+  override async identify(context: LDContext, identifyOptions?: LDIdentifyOptions): Promise<void> {
+    await super.identify(context, identifyOptions);
     this.goalManager?.startTracking();
   }
 >>>>>>> origin/rlamb/fix-browser-contract-test-build