Skip to content

Commit c985daa

Browse files
authored
docs: afterIdentify occurs at a different time than beforeIdentify (#850)
**Requirements** - [ ] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests) - [ ] I have validated my changes against all supported platform versions **Related issues** Found during https://launchdarkly.atlassian.net/browse/DOCS-2295, https://github.com/launchdarkly/ld-docs-private/pull/5935 **Describe the solution you've provided** The `beforeIdentify` and `afterIdentify` methods in the `Hook` interface had identical documentation about when they're called, which is not how they actually behave.
1 parent 1ff4a62 commit c985daa

File tree

1 file changed

+2
-2
lines changed
  • packages/shared/sdk-client/src/api/integrations

1 file changed

+2
-2
lines changed

packages/shared/sdk-client/src/api/integrations/Hooks.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,8 +181,8 @@ export interface Hook {
181181
beforeIdentify?(hookContext: IdentifySeriesContext, data: IdentifySeriesData): IdentifySeriesData;
182182

183183
/**
184-
* This method is called during the execution of the identify process before the operation
185-
* completes, but after any context modifications are performed.
184+
* This method is called during the execution of the identify process, after the operation
185+
* completes.
186186
*
187187
* @param hookContext Contains information about the evaluation being performed. This is not
188188
* mutable.

0 commit comments

Comments
 (0)