fix: Use flag value whenever provided even if variaiton is null or undefined. (#581)

kinyoklion · web-flow · commit d11224c64863 · 2024-09-13T10:30:24.000-07:00
diff --git a/packages/shared/sdk-client/src/LDClientImpl.ts b/packages/shared/sdk-client/src/LDClientImpl.ts
@@ -545,8 +545,8 @@ export default class LDClientImpl implements LDClient {
     }
 
     const successDetail = createSuccessEvaluationDetail(value, variation, reason);
-    if (variation === undefined || variation === null) {
-      this.logger.debug('Result value is null in variation');
+    if (value === undefined || value === null) {
+      this.logger.debug('Result value is null. Providing default value.');
       successDetail.value = defaultValue;
     }
     this.eventProcessor?.sendEvent(

Original file line number	Diff line number	Diff line change
`@@ -545,8 +545,8 @@ export default class LDClientImpl implements LDClient {`
`545`	`545`	`}`
`546`	`546`
`547`	`547`	`const successDetail = createSuccessEvaluationDetail(value, variation, reason);`
`548`		`- if (variation === undefined \|\| variation === null) {`
`549`		`- this.logger.debug('Result value is null in variation');`
	`548`	`+ if (value === undefined \|\| value === null) {`
	`549`	`+ this.logger.debug('Result value is null. Providing default value.');`
`550`	`550`	`successDetail.value = defaultValue;`
`551`	`551`	`}`
`552`	`552`	`this.eventProcessor?.sendEvent(`