making change detection tests a little less sensitive

Author: tanderson-ld

packages/shared/sdk-client/__tests__/LDClientImpl.storage.test.ts

@@ -89,10 +89,8 @@ describe('sdk-client storage', () => {
 
     expect(mockPlatform.storage.get).toHaveBeenCalledWith(flagStorageKey);
 
-    expect(emitter.emit).toHaveBeenCalledTimes(3);
-    expect(emitter.emit).toHaveBeenNthCalledWith(1, 'change', context, defaultFlagKeys);
-    expect(emitter.emit).toHaveBeenNthCalledWith(
-      2,
+    expect(emitter.emit).toHaveBeenCalledWith('change', context, defaultFlagKeys);
+    expect(emitter.emit).toHaveBeenCalledWith(
       'error',
       context,
       expect.objectContaining({ message: 'test-error' }),
@@ -135,15 +133,12 @@ describe('sdk-client storage', () => {
     );
 
     // 'change' should not have been emitted
-    expect(emitter.emit).toHaveBeenCalledTimes(3);
-    expect(emitter.emit).toHaveBeenNthCalledWith(
-      1,
+    expect(emitter.emit).toHaveBeenCalledWith(
       'change',
       expect.objectContaining(toMulti(context)),
       defaultFlagKeys,
     );
-    expect(emitter.emit).toHaveBeenNthCalledWith(
-      2,
+    expect(emitter.emit).toHaveBeenCalledWith(
       'error',
       expect.objectContaining(toMulti(context)),
       expect.objectContaining({ message: 'test-error' }),
@@ -170,15 +165,17 @@ describe('sdk-client storage', () => {
 
     // @ts-ignore
     emitter = ldc.emitter;
-    jest.spyOn(emitter as LDEmitter, 'emit');
+    const spy = jest.spyOn(emitter as LDEmitter, 'emit');
 
     // expect emission
     await ldc.identify(context);
+    expect(emitter.emit).toHaveBeenCalledWith('change', context, defaultFlagKeys);
 
-    // expit no emission
+    // clear the spy so we can tell if change was invoked again
+    spy.mockClear();
+    // expect no emission
     await ldc.identify(context);
-
-    expect(emitter.emit).toHaveBeenCalledTimes(1);
+    expect(emitter.emit).not.toHaveBeenCalledWith('change', context, defaultFlagKeys);
   });
 
   test('no storage, cold start from streaming', async () => {
@@ -251,8 +248,8 @@ describe('sdk-client storage', () => {
       JSON.stringify(putResponse),
     );
 
-    expect(emitter.emit).toHaveBeenNthCalledWith(1, 'change', context, defaultFlagKeys);
-    expect(emitter.emit).toHaveBeenNthCalledWith(2, 'change', context, ['dev-test-flag']);
+    expect(emitter.emit).toHaveBeenCalledWith('change', context, defaultFlagKeys);
+    expect(emitter.emit).toHaveBeenCalledWith('change', context, ['dev-test-flag']);
   });
 
   test('syncing storage when a flag is added', async () => {
@@ -291,7 +288,7 @@ describe('sdk-client storage', () => {
       flagStorageKey,
       JSON.stringify(putResponse),
     );
-    expect(emitter.emit).toHaveBeenNthCalledWith(2, 'change', context, ['another-dev-test-flag']);
+    expect(emitter.emit).toHaveBeenCalledWith('change', context, ['another-dev-test-flag']);
   });
 
   test('syncing storage when a flag is updated', async () => {
@@ -314,7 +311,7 @@ describe('sdk-client storage', () => {
     await jest.runAllTimersAsync();
 
     expect(ldc.allFlags()).toMatchObject({ 'dev-test-flag': false });
-    expect(emitter.emit).toHaveBeenNthCalledWith(2, 'change', context, ['dev-test-flag']);
+    expect(emitter.emit).toHaveBeenCalledWith('change', context, ['dev-test-flag']);
   });
 
   test('syncing storage on multiple flag operations', async () => {
@@ -342,7 +339,7 @@ describe('sdk-client storage', () => {
 
     expect(ldc.allFlags()).toMatchObject({ 'dev-test-flag': false, 'another-dev-test-flag': true });
     expect(ldc.allFlags()).not.toHaveProperty('moonshot-demo');
-    expect(emitter.emit).toHaveBeenNthCalledWith(2, 'change', context, [
+    expect(emitter.emit).toHaveBeenCalledWith('change', context, [
       'moonshot-demo',
       'dev-test-flag',
       'another-dev-test-flag',
@@ -375,8 +372,7 @@ describe('sdk-client storage', () => {
     );
 
     // we expect one change from the local storage init, but no further change from the PUT
-    expect(emitter.emit).toHaveBeenCalledTimes(2);
-    expect(emitter.emit).toHaveBeenNthCalledWith(1, 'change', context, defaultFlagKeys);
+    expect(emitter.emit).toHaveBeenCalledWith('change', context, defaultFlagKeys);
 
     // this is defaultPutResponse
     expect(ldc.allFlags()).toEqual({
@@ -418,7 +414,7 @@ describe('sdk-client storage', () => {
 
     // both previous and current are true but inExperiment has changed
     // so a change event should be emitted
-    expect(emitter.emit).toHaveBeenNthCalledWith(2, 'change', context, ['dev-test-flag']);
+    expect(emitter.emit).toHaveBeenCalledWith('change', context, ['dev-test-flag']);
   });
 
   test('patch should emit change event', async () => {
@@ -447,8 +443,7 @@ describe('sdk-client storage', () => {
     expect(ldc.allFlags()).toMatchObject({ 'dev-test-flag': false });
     expect(mockPlatform.storage.set).toHaveBeenCalledTimes(4);
     expect(flagsInStorage['dev-test-flag'].version).toEqual(patchResponse.version);
-    expect(emitter.emit).toHaveBeenCalledTimes(3);
-    expect(emitter.emit).toHaveBeenNthCalledWith(2, 'change', context, ['dev-test-flag']);
+    expect(emitter.emit).toHaveBeenCalledWith('change', context, ['dev-test-flag']);
   });
 
   test('patch should add new flags', async () => {
@@ -479,8 +474,7 @@ describe('sdk-client storage', () => {
       expect.stringContaining(JSON.stringify(patchResponse)),
     );
     expect(flagsInStorage).toHaveProperty('another-dev-test-flag');
-    expect(emitter.emit).toHaveBeenCalledTimes(3);
-    expect(emitter.emit).toHaveBeenNthCalledWith(2, 'change', context, ['another-dev-test-flag']);
+    expect(emitter.emit).toHaveBeenCalledWith('change', context, ['another-dev-test-flag']);
   });
 
   test('patch should ignore older version', async () => {
@@ -552,8 +546,7 @@ describe('sdk-client storage', () => {
       expect.stringContaining('dev-test-flag'),
     );
     expect(flagsInStorage['dev-test-flag']).toMatchObject({ ...deleteResponse, deleted: true });
-    expect(emitter.emit).toHaveBeenCalledTimes(3);
-    expect(emitter.emit).toHaveBeenNthCalledWith(2, 'change', context, ['dev-test-flag']);
+    expect(emitter.emit).toHaveBeenCalledWith('change', context, ['dev-test-flag']);
   });
 
   test('delete should not delete equal version', async () => {