Skip to content

Commit de613db

Browse files
committed
include sdk name and prefer import over require
1 parent 2c68f5f commit de613db

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

packages/sdk/server-ai/__tests__/LDAIConfigTrackerImpl.test.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
import { LDContext } from '@launchdarkly/js-server-sdk-common';
22

3+
import { name as aiSdkName, version as aiSdkVersion } from '../package.json';
34
import { LDFeedbackKind } from '../src/api/metrics';
45
import { LDAIConfigTrackerImpl } from '../src/LDAIConfigTrackerImpl';
56
import { LDClientMin } from '../src/LDClientMin';
67

7-
// eslint-disable-next-line @typescript-eslint/no-var-requires
8-
const { version: aiSdkVersion } = require('../package.json');
9-
108
const mockTrack = jest.fn();
119
const mockVariation = jest.fn();
1210
const mockLdClient: LDClientMin = {
@@ -27,6 +25,7 @@ const getExpectedTrackData = () => ({
2725
version,
2826
modelName,
2927
providerName,
28+
aiSdkName,
3029
aiSdkVersion,
3130
});
3231

packages/sdk/server-ai/src/LDAIConfigTrackerImpl.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { LDContext } from '@launchdarkly/js-server-sdk-common';
22

3+
import { name as aiSdkName, version as aiSdkVersion } from '../package.json';
34
import { LDAIConfigTracker } from './api/config';
45
import { LDAIMetricSummary } from './api/config/LDAIConfigTracker';
56
import { EvalScore } from './api/judge/types';
@@ -13,8 +14,6 @@ import {
1314
} from './api/metrics';
1415
import { LDClientMin } from './LDClientMin';
1516

16-
const { version } = require('../package.json');
17-
1817
export class LDAIConfigTrackerImpl implements LDAIConfigTracker {
1918
private _trackedMetrics: LDAIMetricSummary = {};
2019

@@ -34,6 +33,7 @@ export class LDAIConfigTrackerImpl implements LDAIConfigTracker {
3433
version: number;
3534
modelName: string;
3635
providerName: string;
36+
aiSdkName: string;
3737
aiSdkVersion: string;
3838
} {
3939
return {
@@ -42,7 +42,8 @@ export class LDAIConfigTrackerImpl implements LDAIConfigTracker {
4242
version: this._version,
4343
modelName: this._modelName,
4444
providerName: this._providerName,
45-
aiSdkVersion: version,
45+
aiSdkName,
46+
aiSdkVersion,
4647
};
4748
}
4849

packages/sdk/server-ai/src/api/config/LDAIConfigTracker.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ export interface LDAIConfigTracker {
4444
version: number;
4545
modelName: string;
4646
providerName: string;
47+
aiSdkName: string;
4748
aiSdkVersion: string;
4849
};
4950
/**

packages/sdk/server-ai/tsconfig.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{
22
"compilerOptions": {
3-
"rootDir": "src",
3+
// Uses "." so it can load package.json.
4+
"rootDir": ".",
45
"outDir": "dist",
56
"target": "es2017",
67
"lib": ["es6"],
@@ -16,6 +17,5 @@
1617
"stripInternal": true,
1718
"moduleResolution": "node"
1819
},
19-
"include": ["src/**/*"],
20-
"exclude": ["**/*.test.ts", "dist", "node_modules", "__tests__"]
20+
"exclude": ["**/*.test.ts", "dist", "node_modules", "__tests__", "examples"]
2121
}

0 commit comments

Comments
 (0)