fix: Update sdk-client rollup configuration to match common

Author: kinyoklion

packages/sdk/react-native/example/App.tsx

@@ -4,17 +4,20 @@ import {
   AutoEnvAttributes,
   LDProvider,
   ReactNativeLDClient,
+  LDOptions,
 } from '@launchdarkly/react-native-client-sdk';
 
 import Welcome from './src/welcome';
 
-const featureClient = new ReactNativeLDClient(MOBILE_KEY, AutoEnvAttributes.Enabled, {
+const options: LDOptions = {
   debug: true,
   applicationInfo: {
     id: 'ld-rn-test-app',
     version: '0.0.1',
   },
-});
+};
+
+const featureClient = new ReactNativeLDClient(MOBILE_KEY, AutoEnvAttributes.Enabled, options);
 
 const App = () => {
   return (

packages/sdk/react-native/example/package.json

@@ -32,6 +32,7 @@
   "devDependencies": {
     "@babel/core": "^7.20.0",
     "@config-plugins/detox": "^8.0.0",
+    "@tsconfig/react-native": "^3.0.5",
     "@types/detox": "^18.1.0",
     "@types/jest": "^29.5.11",
     "@types/node": "^20.10.5",

packages/sdk/react-native/example/src/welcome.tsx

@@ -2,7 +2,7 @@ import { useState } from 'react';
 import { ScrollView, StyleSheet, Text, TextInput, TouchableOpacity, View } from 'react-native';
 
 import { ConnectionMode } from '@launchdarkly/js-client-sdk-common';
-import { useBoolVariation, useLDClient } from '@launchdarkly/react-native-client-sdk';
+import { useBoolVariation, useLDClient, LDContext, LDClientImpl } from '@launchdarkly/react-native-client-sdk';
 
 export default function Welcome() {
   const [flagKey, setFlagKey] = useState('sample-feature');
@@ -12,7 +12,7 @@ export default function Welcome() {
 
   const onIdentify = () => {
     ldc
-      .identify({ kind: 'user', key: userKey }, { timeout: 5 })
+      .identify({ kind: 'user', key: userKey } as LDContext, { timeout: 5 })
       .catch((e: any) => console.error(`error identifying ${userKey}: ${e}`));
   };
 

packages/shared/common/package.json

@@ -19,8 +19,14 @@
     "client"
   ],
   "exports": {
-    "require": { "types": "./dist/cjs/index.d.ts", "default": "./dist/cjs/index.cjs"},
-    "import": { "types": "./dist/esm/index.d.ts", "default": "./dist/esm/index.mjs"}
+    "require": {
+      "types": "./dist/cjs/index.d.ts",
+      "default": "./dist/cjs/index.cjs"
+    },
+    "import": {
+      "types": "./dist/esm/index.d.ts",
+      "default": "./dist/esm/index.mjs"
+    }
   },
   "scripts": {
     "test": "npx jest --ci",

packages/shared/sdk-client/package.json

@@ -2,8 +2,8 @@
   "name": "@launchdarkly/js-client-sdk-common",
   "version": "1.9.0",
   "type": "module",
-  "main": "./dist/index.mjs",
-  "types": "./dist/index.d.ts",
+  "main": "./dist/esm/index.mjs",
+  "types": "./dist/esm/index.d.ts",
   "homepage": "https://github.com/launchdarkly/js-core/tree/main/packages/shared/sdk-client",
   "repository": {
     "type": "git",
@@ -19,14 +19,22 @@
     "client"
   ],
   "exports": {
-    "types": "./dist/index.d.ts",
-    "require": "./dist/index.cjs",
-    "import": "./dist/index.mjs"
+    "require": {
+      "types": "./dist/cjs/index.d.ts",
+      "default": "./dist/cjs/index.cjs"
+    },
+    "import": {
+      "types": "./dist/esm/index.d.ts",
+      "default": "./dist/esm/index.mjs"
+    }
   },
   "scripts": {
     "doc": "../../../scripts/build-doc.sh .",
     "test": "npx jest --ci",
-    "build": "tsc --noEmit && rollup -c rollup.config.js",
+    "make-cjs-package-json": "echo '{\"type\":\"commonjs\"}' > dist/cjs/package.json",
+    "make-esm-package-json": "echo '{\"type\":\"module\"}' > dist/esm/package.json",
+    "make-package-jsons": "npm run make-cjs-package-json && npm run make-esm-package-json",
+    "build": "npx tsc --noEmit && rollup -c rollup.config.js && npm run make-package-jsons",
     "clean": "rimraf dist",
     "lint": "npx eslint . --ext .ts",
     "lint:fix": "yarn run lint -- --fix",

packages/shared/sdk-client/rollup.config.js

@@ -21,7 +21,7 @@ const getSharedConfig = (format, file) => ({
 
 export default [
   {
-    ...getSharedConfig('es', 'dist/index.mjs'),
+    ...getSharedConfig('es', 'dist/esm/index.mjs'),
     plugins: [
       typescript({
         module: 'esnext',
@@ -37,7 +37,7 @@ export default [
     ],
   },
   {
-    ...getSharedConfig('cjs', 'dist/index.cjs'),
-    plugins: [typescript({ tsconfig: './tsconfig.json' }), common(), resolve(), json()],
+    ...getSharedConfig('cjs', 'dist/cjs/index.cjs'),
+    plugins: [typescript({ tsconfig: './tsconfig.json', outputToFilesystem: true, }), common(), resolve(), json()],
   },
 ];