Skip to content

Commit ef8b7b8

Browse files
authored
feat: Adding CreatePlatformInfo for Akamai SDK (#122)
Adding the Create platform class and test for the Akamai SDK Added `@launchdarkly/js-server-sdk-common-edge` dependency Removed unnecessary file inclusion from tsconfig
2 parents bf37f3d + 3d6fdc6 commit ef8b7b8

File tree

7 files changed

+63
-14
lines changed

7 files changed

+63
-14
lines changed

.github/workflows/akamai.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,5 @@ jobs:
2020
name: Shared CI Steps
2121
uses: ./actions/ci
2222
with:
23-
workspace_name: '@launchdarkly/akamai-server-sdk'
23+
workspace_name: '@launchdarkly/akamai-edgeworker-sdk'
2424
workspace_path: packages/sdk/akamai

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ This includes shared libraries, used by SDKs and other tools, as well as SDKs.
1010
| [@launchdarkly/cloudflare-server-sdk](packages/sdk/cloudflare/README.md) | [![NPM][sdk-cloudflare-npm-badge]][sdk-cloudflare-npm-link] | [Cloudflare][package-sdk-cloudflare-issues] | [![Actions Status][sdk-cloudflare-ci-badge]][sdk-cloudflare-ci] |
1111
| [@launchdarkly/node-server-sdk](packages/sdk/server-node/README.md) | [![NPM][sdk-server-node-npm-badge]][sdk-server-node-npm-link] | [Node.js Server][package-sdk-server-node-issues] | [![Actions Status][sdk-server-node-ci-badge]][sdk-server-node-ci] |
1212
| [@launchdarkly/vercel-server-sdk](packages/sdk/vercel/README.md) | [![NPM][sdk-vercel-npm-badge]][sdk-vercel-npm-link] | [Vercel][package-sdk-vercel-issues] | [![Actions Status][sdk-vercel-ci-badge]][sdk-vercel-ci] |
13-
| [@launchdarkly/akamai-server-sdk](packages/sdk/akamai/README.md) | [![NPM][sdk-akamai-npm-badge]][sdk-akamai-npm-link] | [Akamai][package-sdk-akamai-issues] | [![Actions Status][sdk-akamai-ci-badge]][sdk-akamai-ci] |
13+
| [@launchdarkly/akamai-edgeworker-sdk](packages/sdk/akamai/README.md) | [![NPM][sdk-akamai-npm-badge]][sdk-akamai-npm-link] | [Akamai][package-sdk-akamai-issues] | [![Actions Status][sdk-akamai-ci-badge]][sdk-akamai-ci] |
1414

1515
| Shared packages | npm | issues | tests |
1616
| ------------------------------------------------------------------------------------ | ------------------------------------------------------------------------- | ----------------------------------------------------------- | ------------------------------------------------------------------------------- |
@@ -101,10 +101,10 @@ We encourage pull requests and other contributions from the community. Check out
101101
[//]: # 'sdk/akamai'
102102
[sdk-akamai-ci-badge]: https://github.com/launchdarkly/js-core/actions/workflows/akamai.yml/badge.svg
103103
[sdk-akamai-ci]: https://github.com/launchdarkly/js-core/actions/workflows/akamai.yml
104-
[sdk-akamai-npm-badge]: https://img.shields.io/npm/v/@launchdarkly/akamai-server-sdk.svg?style=flat-square
105-
[sdk-akamai-npm-link]: https://www.npmjs.com/package/@launchdarkly/akamai-server-sdk
104+
[sdk-akamai-npm-badge]: https://img.shields.io/npm/v/@launchdarkly/akamai-edgeworker-sdk.svg?style=flat-square
105+
[sdk-akamai-npm-link]: https://www.npmjs.com/package/@launchdarkly/akamai-edgeworker-sdk
106106
[sdk-akamai-ghp-badge]: https://img.shields.io/static/v1?label=GitHub+Pages&message=API+reference&color=00add8
107107
[sdk-akamai-ghp-link]: https://launchdarkly.github.io/js-core/packages/sdk/akamai/docs/
108-
[sdk-akamai-dm-badge]: https://img.shields.io/npm/dm/@launchdarkly/akamai-server-sdk.svg?style=flat-square
109-
[sdk-akamai-dt-badge]: https://img.shields.io/npm/dt/@launchdarkly/akamai-server-sdk.svg?style=flat-square
108+
[sdk-akamai-dm-badge]: https://img.shields.io/npm/dm/@launchdarkly/akamai-edgeworker-sdk.svg?style=flat-square
109+
[sdk-akamai-dt-badge]: https://img.shields.io/npm/dt/@launchdarkly/akamai-edgeworker-sdk.svg?style=flat-square
110110
[package-sdk-akamai-issues]: https://github.com/launchdarkly/js-core/issues?q=is%3Aissue+is%3Aopen+label%3A%22package%3A+sdk%2Fakamai%22+

packages/sdk/akamai/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ For more information, see the [complete reference guide for this SDK](https://do
1313
## Install
1414

1515
```shell
16-
npm i @launchdarkly/akamai-server-sdk
16+
npm i @launchdarkly/akamai-edgeworker-sdk
1717
```
1818

1919
Then turn on the Node.js compatibility flag in your `wrangler.toml`. This allows the SDK to use `node:events`:
@@ -53,9 +53,9 @@ yarn test
5353

5454
[sdk-akamai-ci-badge]: https://github.com/launchdarkly/js-core/actions/workflows/akamai.yml/badge.svg
5555
[sdk-akamai-ci]: https://github.com/launchdarkly/js-core/actions/workflows/akamai.yml
56-
[sdk-akamai-npm-badge]: https://img.shields.io/npm/v/@launchdarkly/akamai-server-sdk.svg?style=flat-square
57-
[sdk-akamai-npm-link]: https://www.npmjs.com/package/@launchdarkly/akamai-server-sdk
56+
[sdk-akamai-npm-badge]: https://img.shields.io/npm/v/@launchdarkly/akamai-edgeworker-sdk.svg?style=flat-square
57+
[sdk-akamai-npm-link]: https://www.npmjs.com/package/@launchdarkly/akamai-edgeworker-sdk
5858
[sdk-akamai-ghp-badge]: https://img.shields.io/static/v1?label=GitHub+Pages&message=API+reference&color=00add8
5959
[sdk-akamai-ghp-link]: https://launchdarkly.github.io/js-core/packages/sdk/akamai/docs/
60-
[sdk-akamai-dm-badge]: https://img.shields.io/npm/dm/@launchdarkly/akamai-server-sdk.svg?style=flat-square
61-
[sdk-akamai-dt-badge]: https://img.shields.io/npm/dt/@launchdarkly/akamai-server-sdk.svg?style=flat-square
60+
[sdk-akamai-dm-badge]: https://img.shields.io/npm/dm/@launchdarkly/akamai-edgeworker-sdk.svg?style=flat-square
61+
[sdk-akamai-dt-badge]: https://img.shields.io/npm/dt/@launchdarkly/akamai-edgeworker-sdk.svg?style=flat-square

packages/sdk/akamai/package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "@launchdarkly/akamai-server-sdk",
2+
"name": "@launchdarkly/akamai-edgeworker-sdk",
33
"version": "0.0.1",
44
"description": "Akamai LaunchDarkly SDK",
55
"homepage": "https://github.com/launchdarkly/js-core/tree/main/packages/sdk/akamai",
@@ -37,7 +37,9 @@
3737
"coverage": "yarn test --coverage",
3838
"check": "yarn prettier && yarn lint && yarn build && yarn test && yarn doc"
3939
},
40-
"dependencies": {},
40+
"dependencies": {
41+
"@launchdarkly/js-server-sdk-common-edge": "^1.0.2"
42+
},
4143
"devDependencies": {
4244
"@types/jest": "^29.5.1",
4345
"@typescript-eslint/eslint-plugin": "^5.57.0",
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
import createPlatformInfo from './createPlatformInfo';
2+
3+
const packageJson = require('../package.json');
4+
5+
describe('Akamai Platform Info', () => {
6+
it('platformData shows correct information', () => {
7+
const platformData = createPlatformInfo();
8+
9+
expect(platformData.platformData()).toEqual({
10+
name: 'Akamai EdgeWorker',
11+
});
12+
});
13+
14+
it('sdkData shows correct information', () => {
15+
const platformData = createPlatformInfo();
16+
17+
expect(platformData.sdkData()).toEqual({
18+
name: packageJson.name,
19+
version: packageJson.version,
20+
});
21+
});
22+
});
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
import type { Info, PlatformData, SdkData } from '@launchdarkly/js-server-sdk-common-edge';
2+
3+
/*
4+
TODO:
5+
Add to release-please-config.json when ready for release
6+
This is needed to update the version number for sdkData
7+
*/
8+
class AkamaiPlatformInfo implements Info {
9+
platformData(): PlatformData {
10+
return {
11+
name: 'Akamai EdgeWorker',
12+
};
13+
}
14+
15+
sdkData(): SdkData {
16+
return {
17+
name: '@launchdarkly/akamai-edgeworker-sdk',
18+
version: '0.0.1', // {x-release-please-version}
19+
};
20+
}
21+
}
22+
23+
const createPlatformInfo = () => new AkamaiPlatformInfo();
24+
25+
export default createPlatformInfo;

packages/sdk/akamai/tsconfig.ref.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"extends": "./tsconfig.json",
3-
"include": ["src/**/*", "package.json", "src/**/testData.json"],
3+
"include": ["src/**/*", "package.json"],
44
"compilerOptions": {
55
"composite": true
66
}

0 commit comments

Comments
 (0)