diff --git a/packages/sdk/browser/contract-tests/entity/package.json b/packages/sdk/browser/contract-tests/entity/package.json index 90b9433a14..1355a1a1f8 100644 --- a/packages/sdk/browser/contract-tests/entity/package.json +++ b/packages/sdk/browser/contract-tests/entity/package.json @@ -5,7 +5,8 @@ "type": "module", "description": "Contract test service implementation for @launchdarkly/js-client-sdk", "scripts": { - "start": "vite --open=true", + "start": "tsc --noEmit && vite --open=true", + "build": "tsc --noEmit && vite build", "lint": "eslint ./src", "prettier": "prettier --write '**/*.@(js|ts|tsx|json|css)' --ignore-path ../../../../.prettierignore" }, diff --git a/packages/sdk/browser/contract-tests/entity/src/ClientEntity.ts b/packages/sdk/browser/contract-tests/entity/src/ClientEntity.ts index e7cbd756ca..5e0fbf664e 100644 --- a/packages/sdk/browser/contract-tests/entity/src/ClientEntity.ts +++ b/packages/sdk/browser/contract-tests/entity/src/ClientEntity.ts @@ -1,10 +1,4 @@ -import { - AutoEnvAttributes, - init, - LDClient, - LDLogger, - LDOptions, -} from '@launchdarkly/js-client-sdk'; +import { init, LDClient, LDLogger, LDOptions } from '@launchdarkly/js-client-sdk'; import { CommandParams, CommandType, ValueType } from './CommandParams'; import { CreateInstanceParams, SDKConfigParams } from './ConfigParams'; @@ -72,6 +66,8 @@ function makeSdkConfig(options: SDKConfigParams, tag: string) { }; } + cf.fetchGoals = false; + return cf; } @@ -205,11 +201,7 @@ export async function newSdkClientEntity(options: CreateInstanceParams) { options.configuration.clientSide?.initialUser || options.configuration.clientSide?.initialContext || makeDefaultInitialContext(); - const client = init( - options.configuration.credential || 'unknown-env-id', - AutoEnvAttributes.Disabled, // TODO: Determine capability. - sdkConfig, - ); + const client = init(options.configuration.credential || 'unknown-env-id', sdkConfig); let failed = false; try { await Promise.race([ diff --git a/packages/sdk/browser/src/BrowserClient.ts b/packages/sdk/browser/src/BrowserClient.ts index a275fddccd..59a1b817a7 100644 --- a/packages/sdk/browser/src/BrowserClient.ts +++ b/packages/sdk/browser/src/BrowserClient.ts @@ -10,6 +10,7 @@ import { LDContext, Platform, } from '@launchdarkly/js-client-sdk-common'; +import { LDIdentifyOptions } from '@launchdarkly/js-client-sdk-common/dist/api/LDIdentifyOptions'; import GoalManager from './goals/GoalManager'; import { Goal, isClick } from './goals/Goals'; @@ -135,8 +136,8 @@ export class BrowserClient extends LDClientImpl { }; } - override async identify(context: LDContext): Promise { - await super.identify(context); + override async identify(context: LDContext, identifyOptions?: LDIdentifyOptions): Promise { + await super.identify(context, identifyOptions); this.goalManager?.startTracking(); } }