chore: test pipeline #935
Closed
chore: test pipeline #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements support for a maintenance branch for creating node-server-sdk releases. It removes all builds related to other packages and can only build/release node-server-sdk.
… promise rejection. (launchdarkly#374) This is a cherry-pick from the 9.x release. --------- Co-authored-by: Yusinto Ngadiman <[email protected]>
🤖 I have created a release *beep* *boop* --- <details><summary>node-server-sdk: 8.2.5</summary> ## [8.2.5](launchdarkly/js-core@node-server-sdk-v8.2.4...node-server-sdk-v8.2.5) (2024-02-12) ### Bug Fixes * Fix an issue where failed http requests could cause an unhandled promise rejection. ([launchdarkly#374](launchdarkly#374)) ([ecfd2db](launchdarkly@ecfd2db)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR is to prevent 8.x docs from overwriting 9.x docs. In the future we may want to consider docs for multiple versions, but we do not currently support that.
🤖 I have created a release *beep* *boop* --- <details><summary>node-server-sdk: 8.2.6</summary> ## [8.2.6](launchdarkly/js-core@node-server-sdk-v8.2.5...node-server-sdk-v8.2.6) (2024-05-21) ### Bug Fixes * Configure max backoff and jitter ratio to ensure exponential backoff. ([launchdarkly#464](launchdarkly#464)) ([87563cb](launchdarkly@87563cb)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
feat: adjust node-server-sdk-redis for codefresh
fix: optimize algorithm
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| results.push({ key, item: { version: 0, deleted: false, serializedItem: value } }); | ||
| }); | ||
| callback(results); | ||
| callback(this.#prepareArray(values)); |
There was a problem hiding this comment.
Bug: Redis Fallback Failures and Error Handling
The getAll method has a couple of issues with its error and fallback handling. When the Redis connection is down or a MaxRetriesPerRequestError occurs, calling the localFeatureStore fallback doesn't stop further execution, which can lead to redundant Redis operations and the callback being invoked multiple times. Additionally, if hgetall encounters any other error, the callback is never called, potentially causing the calling code to hang.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.
Note
Sets up 8.x maintenance branch CI/release, bumps @launchdarkly/node-server-sdk to 8.2.6 with SSE backoff and safer response handling, and adds Redis store fallback/reconnect improvements plus maintenance-tag publishing.
packages/sdk/server-node):maxBackoffMillis,jitterRatio) inNodeRequests.createEventSource.NodeResponseto propagate errors even if body isn’t awaited; add tests for interrupted/partial responses.8.2.6; update CHANGELOG.packages/store/node-server-sdk-redis):getAllto fall back to a providedlocalFeatureStorewhen Redis is down or onMaxRetriesPerRequestError.localFeatureStorethroughRedisFeatureStoreandRedisFeatureStoreFactory.node-server-sdk-8.x: updateserver-nodeworkflow triggers andrelease-pleasedefault branch; conditionally publish docs.maintenancetag (scripts/publish.sh)..nvmrc(Node 20.18.0); update release manifest.@launchdarkly/node-server-sdk8.x maintenance.Written by Cursor Bugbot for commit f2f732c. This will update automatically on new commits. Configure here.