chore: adding shopify oxygen example #997
Conversation
joker23
force-pushed
the
szhang/sdk-1556/oxygen-sdk-hello-example
branch
from
0199d73 to
4b21616
Compare
|
@launchdarkly/browser size report |
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/js-client-sdk-common size report |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
joker23
force-pushed
the
szhang/sdk-1556/oxygen-sdk-hello-example
branch
from
4b21616 to
842b764
Compare
| process.exit(); | ||
| } | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Bug: Unhandled Promises Threaten Application Stability
The miniOxygen.ready.then() promise chain lacks error handling. If miniOxygen.ready rejects, it will cause an unhandled promise rejection since the promise chain is detached from the main() function's error handling. This could cause the application to crash or behave unexpectedly without proper error reporting.
| console.log('Error dispatching fetch:', err.message); | ||
| console.log('Press "q" or Ctrl+C to quit...') | ||
| }); | ||
| }, 1000); |
There was a problem hiding this comment.
Bug: Polling Frequency Mismatch: Documentation vs. Reality
The console message and comment state "Dispatching fetch every 5 seconds" but the setInterval uses 1000 milliseconds (1 second). This mismatch between documentation and implementation means the application polls 5 times more frequently than users are told to expect.
This PR will add an example application for Shopify Oxygen SDK
Note
Adds a Shopify Oxygen SDK example app with a mini-oxygen runner and updates the root workspaces to include it.
packages/sdk/shopify-oxygen/example):src/index.tsthat initializes the SDK, evaluates a flag, and returns{ flagKey, flagValue }.app.jsrunner using@shopify/mini-oxygento execute the built worker and periodically print flag results.package.json(scripts/deps),tsconfig.json,tsup.config.ts, and a README with usage instructions.package.jsonworkspaces to includepackages/sdk/shopify-oxygen/example.Written by Cursor Bugbot for commit 571a063. This will update automatically on new commits. Configure here.