Skip to content

Commit bfbc9a9

Browse files
fix: add objectHasOwnProperty checks to flagStore
Ensures consistent property validation.
1 parent 8a7f2ff commit bfbc9a9

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

src/index.js

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,14 +89,17 @@ function initialize(env, context, specifiedOptions, platform, extraOptionDefs) {
8989
const flagStore = {
9090
get(key) {
9191
// Check overrides first, then real flags
92-
const override = flagOverrides && flagOverrides[key];
93-
if (override && !override.deleted) {
94-
return override;
92+
if (
93+
flagOverrides &&
94+
utils.objectHasOwnProperty(flagOverrides, key) &&
95+
flagOverrides[key] &&
96+
!flagOverrides[key].deleted
97+
) {
98+
return flagOverrides[key];
9599
}
96100

97-
const real = flags && flags[key];
98-
if (real && !real.deleted) {
99-
return real;
101+
if (flags && utils.objectHasOwnProperty(flags, key) && flags[key] && !flags[key].deleted) {
102+
return flags[key];
100103
}
101104

102105
return null;
@@ -115,11 +118,13 @@ function initialize(env, context, specifiedOptions, platform, extraOptionDefs) {
115118
return result;
116119
},
117120

121+
// Do we need this?
118122
exists(key) {
119123
return this.get(key) !== null;
120124
},
121125

122126
// Helper to get all keys that have flags (real or override)
127+
// Do we need this?
123128
getAllKeys() {
124129
return new Set([...Object.keys(flags || {}), ...Object.keys(flagOverrides || {})]);
125130
},

0 commit comments

Comments
 (0)