chore: [REL-4161] fix up tag checks (#558)

Two things being updated here:
1. update the tag-check (for this repo) to only check the remote repo
for the tag. It will definitely exist in the local copy since we need to
create it before running Goreleaser. Other minor tweak is that instead
of bailing on the entire action, we just return 0, so the action can
continue to run and complete the final step of creating the Github
release. The only reason we're likely to be running the action again if
the tag was created, is that the Github release failed, so we want to
let the action continue, so it can do that last step.
2. checking for existing tag (GHA and Bitbucket Pipe) on dry-run as
well. This was fixed for real runs of the action, but dry-runs will also
bomb out if the tag exists (the tag could exist if we previously had a
partially successful run, but need to re-run the action to retry the
parts that didn't complete successfully)
<!-- ld-jira-link -->
---
Related Jira issue: [REL-4161: Migrate ld-find-code-refs from Releaser
to GHA](https://launchdarkly.atlassian.net/browse/REL-4161)
<!-- end-ld-jira-link -->

Author: blaqbern

scripts/release/push-to-origin.sh

@@ -2,21 +2,20 @@
 
 set -euo pipefail
 
-release_tag="v${LD_RELEASE_VERSION}"
+release_tag="v$LD_RELEASE_VERSION"
 
 tag_exists() (
-  git fetch --tags
-  git rev-parse "${release_tag}" >/dev/null 2>&1
+  git ls-remote --tags [email protected]:launchdarkly/ld-find-code-refs.git "refs/tags/$release_tag" | grep -q "$release_tag"
 )
 
 push_to_origin() (
   if tag_exists; then
     echo "Tag $release_tag already exists. Aborting."
-    exit 1
+    return 0
   fi
 
   git push origin HEAD
-  git push origin "${release_tag}"
+  git push origin "$release_tag"
 )
 
 if [[ "$DRY_RUN" == "true" ]]; then

scripts/release/targets/bitbucket.sh

@@ -21,23 +21,33 @@ clean_up_bitbucket() (
   cd .. && rm -rf bitbucketMetadataUpdates
 )
 
+tag_exists() (
+  git ls-remote --tags https://bitbucket.org/launchdarkly/ld-find-code-refs-pipe.git "refs/tags/v$LD_RELEASE_VERSION" | grep -q "v$LD_RELEASE_VERSION"
+)
+
 publish_bitbucket() (
-  if git ls-remote --tags https://bitbucket.org/launchdarkly/ld-find-code-refs-pipe.git "refs/tags/v$LD_RELEASE_VERSION" | grep -q "v$LD_RELEASE_VERSION"; then
+  if tag_exists; then
     echo "Version exists; skipping publishing BitBucket Pipe"
-  else
-    setup_bitbucket
+    return 0
+  fi
 
-    echo "Live run: will publish pipe to bitbucket."
+  setup_bitbucket
 
-    cd bitbucketMetadataUpdates
-    git tag "$LD_RELEASE_VERSION"
-    git push bb-origin master --tags
+  echo "Live run: will publish pipe to bitbucket."
 
-    clean_up_bitbucket
-  fi
+  cd bitbucketMetadataUpdates
+  git tag "$LD_RELEASE_VERSION"
+  git push bb-origin master --tags
+
+  clean_up_bitbucket
 )
 
 dry_run_bitbucket() (
+  if tag_exists; then
+    echo "Version exists; skipping push dry-run BitBucket Pipe"
+    return 0
+  fi
+
   setup_bitbucket
 
   echo "Dry run: will not publish pipe to bitbucket."

scripts/release/targets/gha.sh

@@ -36,27 +36,37 @@ clean_up_gha() (
   cd .. && rm -rf githubActionsMetadataUpdates
 )
 
+tag_exists() (
+  git ls-remote --tags [email protected]:launchdarkly/find-code-references.git "refs/tags/v$LD_RELEASE_VERSION" | grep -q "v$LD_RELEASE_VERSION"
+)
+
 publish_gha() (
-  if git ls-remote --tags [email protected]:launchdarkly/find-code-references.git "refs/tags/v$LD_RELEASE_VERSION" | grep -q "v$LD_RELEASE_VERSION"; then
+  if tag_exists; then
     echo "Version exists; skipping publishing GHA"
-  else
-    setup_gha
+    return 0
+  fi
 
-    echo "Live run: will publish action to github action marketplace."
+  setup_gha
 
-    cd githubActionsMetadataUpdates
-    # tag the commit with the release version and create release
-    git tag "$RELEASE_TAG"
-    git push origin main --tags
-    git tag -f "$RELEASE_TAG_MAJOR"
-    git push -f origin "$RELEASE_TAG_MAJOR"
-    gh release create "$RELEASE_TAG" --notes "$RELEASE_NOTES"
+  echo "Live run: will publish action to github action marketplace."
 
-    clean_up_gha
-  fi
+  cd githubActionsMetadataUpdates
+  # tag the commit with the release version and create release
+  git tag "$RELEASE_TAG"
+  git push origin main --tags
+  git tag -f "$RELEASE_TAG_MAJOR"
+  git push -f origin "$RELEASE_TAG_MAJOR"
+  gh release create "$RELEASE_TAG" --notes "$RELEASE_NOTES"
+
+  clean_up_gha
 )
 
 dry_run_gha() (
+  if tag_exists; then
+    echo "Version exists; skipping push dry-run GHA"
+    return 0
+  fi
+
   setup_gha
 
   echo "Dry run: will not publish action to github action marketplace."