dont patch repos when url generation templates args are not provided (#56)

* don't patch url templates if cli arguments aren't provided

* update changelog

Author: atrakh

CHANGELOG.md

@@ -7,10 +7,14 @@ All notable changes to the ld-find-code-refs program will be documented in this
 ### Added
 - Added support for relative paths to CLI `-dir` parameter.
 - Added a new command line argument, `debug`, which enables verbose debug logging.
-- `ld-find-code-refs` will now exit early if required dependencies are not installed on the system PATH
+- `ld-find-code-refs` will now exit early if required dependencies are not installed on the system PATH.
 
 ### Changed
-- Renamed `parse` package to `coderefs`. The `Parse()` method in the aformentioned package is now `Scan()`
+- Renamed `parse` package to `coderefs`. The `Parse()` method in the aformentioned package is now `Scan()`.
+
+### Fixed
+- `ld-find-code-refs` will no longer erroneously make PATCH API requests to LaunchDarkly when url template parameters have not been configured.
+
 
 ## [0.3.0] - 2019-01-23
 

internal/ld/ld.go

@@ -177,6 +177,18 @@ func (c ApiClient) MaybeUpsertCodeReferenceRepository(repo RepoParams) error {
 			CommitUrlTemplate: currentRepo.CommitUrlTemplate,
 			HunkUrlTemplate:   currentRepo.HunkUrlTemplate,
 		}
+
+		// Don't patch templates if command line arguments are not provided.
+		// This is done because the LaunchDarkly API may return autogenerated url templates for non-custom connections.
+		if currentRepo.Type != "custom" {
+			if repo.CommitUrlTemplate == "" {
+				currentRepoParams.CommitUrlTemplate = ""
+			}
+			if repo.HunkUrlTemplate == "" {
+				currentRepoParams.HunkUrlTemplate = ""
+			}
+		}
+
 		if !reflect.DeepEqual(currentRepoParams, repo) {
 			err = c.patchCodeReferenceRepository(currentRepoParams, repo)
 			if err != nil {