[REL-4161] fix syntax error; add a bit more logging (#522)

Hopefully this will be the last one 😅.
Yesterday evening I added the CHANGELOG update which I had overlooked
initially because Releaser did it behind-the-scenes. But there was an
extra `)` in the code 🤦, so that's fixed here, and I'm also logging out
the changelog so future releasers will be able to see the diff and the
updated CHANGELOG when they run a dry run or actual release. There's
also a minor refactor here. It's nothing big, but it makes the updates a
bit harder to grok, so I'll try to comment in the code to explain what
was changed.
<!-- ld-jira-link -->
---
Related Jira issue: [REL-4161: Migrate ld-find-code-refs from Releaser
to GHA](https://launchdarkly.atlassian.net/browse/REL-4161)
<!-- end-ld-jira-link -->

Author: blaqbern

scripts/release/commit-and-tag.sh

@@ -10,33 +10,36 @@ tag_exists() (
 )
 
 update_changelog() (
-  local ts=$(date +"%Y-%m-%d"))
+  local ts=$(date +"%Y-%m-%d")
   local changelog_entry=$(cat << EOF
 ## [$LD_RELEASE_VERSION] - $ts
 $CHANGELOG_ENTRY
 EOF
-  )
 
   # insert the new changelog entry (followed by empty line) after line 4
   # of CHANGELOG.md
   sed -i "4r /dev/stdin" CHANGELOG.md <<< "$changelog_entry"$'\n'
+)
+
+release_summary() (
+  echo
+  echo "Changes staged for release $RELEASE_TAG:"
+  git diff
 
+  echo
+  echo "Updated CHANGELOG:"
   cat CHANGELOG.md
+  echo
 )
 
-echo "Changes staged for release $RELEASE_TAG:"
-git diff
-
-if [[ "$DRY_RUN" == "true" ]]; then
-  echo "Dry run mode: skipping commit, tag, and push"
-  update_changelog
-else
+commit_and_tag() (
   if tag_exists; then
     echo "Tag $RELEASE_TAG already exists. Aborting."
     exit 1
   fi
 
   update_changelog
+  release_summary
 
   git config user.name "LaunchDarklyReleaseBot"
   git config user.email "[email protected]"
@@ -45,5 +48,13 @@ else
   git tag "${RELEASE_TAG}"
   git push origin HEAD
   git push origin "${RELEASE_TAG}"
+)
+
+if [[ "$DRY_RUN" == "true" ]]; then
+  update_changelog
+  release_summary
+  echo "Dry run mode: skipping commit, tag, and push"
+else
+  commit_and_tag
 fi