fix: Redact Redis password from Big Segment logs (#555)

fixes #550

Author: keelerm84

internal/sdks/big_segments.go

@@ -2,6 +2,7 @@ package sdks
 
 import (
 	"github.com/launchdarkly/ld-relay/v8/config"
+	"github.com/launchdarkly/ld-relay/v8/internal/util"
 
 	"github.com/launchdarkly/go-sdk-common/v3/ldlog"
 	"github.com/launchdarkly/go-server-sdk/v7/ldcomponents"
@@ -24,7 +25,8 @@ func ConfigureBigSegments(
 
 	if allConfig.Redis.URL.IsDefined() {
 		redisBuilder, redisURL := makeRedisDataStoreBuilder(ldredis.BigSegmentStore, allConfig, envConfig)
-		loggers.Infof("Using Redis big segment store: %s with prefix: %s", redisURL, envConfig.Prefix)
+		redactedURL := util.RedactURL(redisURL)
+		loggers.Infof("Using Redis big segment store: %s with prefix: %s", redactedURL, envConfig.Prefix)
 		storeFactory = redisBuilder
 	} else if allConfig.DynamoDB.Enabled {
 		dynamoDBBuilder, tableName, err := makeDynamoDBDataStoreBuilder(lddynamodb.BigSegmentStore, allConfig, envConfig)

internal/sdks/big_segments_test.go

@@ -50,6 +50,14 @@ func TestBigSegmentsRedis(t *testing.T) {
 		log.AssertMessageMatch(t, true, ldlog.Info, "Using Redis big segment store: "+redisURL)
 	})
 
+	t.Run("password is redacted in log", func(t *testing.T) {
+		urlWithPassword := "redis://username:very-secret-password@redishost:3000"
+		var c config.Config
+		c.Redis.URL, _ = configtypes.NewOptURLAbsoluteFromString(urlWithPassword)
+		log := assertBigSegmentsConfigured(t, c, config.EnvConfig{})
+		log.AssertMessageMatch(t, false, ldlog.Info, "very-secret-password")
+	})
+
 	t.Run("prefix", func(t *testing.T) {
 		c := config.Config{
 			Redis: config.RedisConfig{