Skip to content

Commit 104772e

Browse files
committed
Add query
1 parent 5e02e7b commit 104772e

File tree

4 files changed

+16
-13
lines changed

4 files changed

+16
-13
lines changed

internal/dev_server/events_db/sqlite.go

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ func (s *Sqlite) WriteEvent(ctx context.Context, debugSessionKey string, kind st
2929
return err
3030
}
3131

32-
func (s *Sqlite) QueryEvents(ctx context.Context, kind *string, limit int, offset int) (*model.EventsPage, error) {
32+
func (s *Sqlite) QueryEvents(ctx context.Context, debugSessionKey string, kind *string, limit int, offset int) (*model.EventsPage, error) {
3333
// Build the query based on whether kind filter is provided
3434
var query string
3535
var args []interface{}
@@ -38,17 +38,20 @@ func (s *Sqlite) QueryEvents(ctx context.Context, kind *string, limit int, offse
3838
query = `
3939
SELECT id, written_at, kind, data
4040
FROM debug_events
41-
WHERE kind = ?
41+
WHERE
42+
debug_session_key = ?
43+
AND kind = ?
4244
ORDER BY id DESC
4345
LIMIT ? OFFSET ?`
44-
args = []interface{}{*kind, limit, offset}
46+
args = []interface{}{debugSessionKey, *kind, limit, offset}
4547
} else {
4648
query = `
4749
SELECT id, written_at, kind, data
4850
FROM debug_events
51+
where debug_session_key = ?
4952
ORDER BY id DESC
5053
LIMIT ? OFFSET ?`
51-
args = []interface{}{limit, offset}
54+
args = []interface{}{debugSessionKey, limit, offset}
5255
}
5356

5457
// Execute the main query

internal/dev_server/events_db/sqlite_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ func TestDBFunctions(t *testing.T) {
5757
require.NoError(t, err)
5858

5959
// Query all events
60-
page, err := store.QueryEvents(ctx, nil, 10, 0)
60+
page, err := store.QueryEvents(ctx, debugSessionKey, nil, 10, 0)
6161
require.NoError(t, err)
6262
require.NotNil(t, page)
6363
require.Len(t, page.Events, 4) // 3 new + 1 from previous test
@@ -67,7 +67,7 @@ func TestDBFunctions(t *testing.T) {
6767

6868
t.Run("QueryEvents with kind filter", func(t *testing.T) {
6969
kind := "summary"
70-
page, err := store.QueryEvents(ctx, &kind, 10, 0)
70+
page, err := store.QueryEvents(ctx, debugSessionKey, &kind, 10, 0)
7171
require.NoError(t, err)
7272
require.NotNil(t, page)
7373
require.Len(t, page.Events, 3) // Only summary events
@@ -82,15 +82,15 @@ func TestDBFunctions(t *testing.T) {
8282

8383
t.Run("QueryEvents with pagination", func(t *testing.T) {
8484
// Query with limit
85-
page, err := store.QueryEvents(ctx, nil, 2, 0)
85+
page, err := store.QueryEvents(ctx, debugSessionKey, nil, 2, 0)
8686
require.NoError(t, err)
8787
require.NotNil(t, page)
8888
require.Len(t, page.Events, 2)
8989
require.Equal(t, int64(4), page.TotalCount)
9090
require.True(t, page.HasMore)
9191

9292
// Query next page
93-
page, err = store.QueryEvents(ctx, nil, 2, 2)
93+
page, err = store.QueryEvents(ctx, debugSessionKey, nil, 2, 2)
9494
require.NoError(t, err)
9595
require.NotNil(t, page)
9696
require.Len(t, page.Events, 2)

internal/dev_server/model/event_store.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ type EventsPage struct {
3333
type EventStore interface {
3434
CreateDebugSession(ctx context.Context, debugSessionKey string) error
3535
WriteEvent(ctx context.Context, debugSessionKey string, kind string, data json.RawMessage) error
36-
QueryEvents(ctx context.Context, kind *string, limit int, offset int) (*EventsPage, error)
36+
QueryEvents(ctx context.Context, debugSessionKey string, kind *string, limit int, offset int) (*EventsPage, error)
3737
}
3838

3939
func ContextWithEventStore(ctx context.Context, store EventStore) context.Context {

internal/dev_server/model/mocks/event_store.go

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)