fix: [REL-8111] [rel-8111] investigate and fix ldcli returning zero error code on failure (#589)

sloloris · web-flow · commit 1ff210e79d08 · 2025-07-28T15:23:54.000+02:00
* fix

* add note to readme on running locally

* set 1 exit command when error
diff --git a/cmd/root.go b/cmd/root.go
@@ -270,6 +270,7 @@ See each command's help for details on how to use the generated script.`, rootCm
 	case err != nil:
 		outcome = analytics.ERROR
 		fmt.Fprintln(os.Stderr, err.Error())
+		os.Exit(1)
 	default:
 		outcome = analytics.SUCCESS
 	}

Original file line number	Diff line number	Diff line change
@@ -270,6 +270,7 @@ See each command's help for details on how to use the generated script.`, rootCm
`270`	`270`	`case err != nil:`
`271`	`271`	`outcome = analytics.ERROR`
`272`	`272`	`fmt.Fprintln(os.Stderr, err.Error())`
	`273`	`+ os.Exit(1)`
`273`	`274`	`default:`
`274`	`275`	`outcome = analytics.SUCCESS`
`275`	`276`	`}`