Skip to content

Commit 326c0de

Browse files
authored
fix: correct CORS header name for exposing date in dev-server (#573)
This fixes a provlem where the header `date` still fails in the browser with a message even though it seems to be covered by `Access-Control-Expose-Headers` header, by removing an additional `:` that existed in the CORS header name.
1 parent f266332 commit 326c0de

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

internal/dev_server/sdk/cors.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ func CorsHeaders(handler http.Handler) http.Handler {
88
writer.Header().Set("Access-Control-Allow-Methods", "GET,OPTIONS")
99
writer.Header().Set("Access-Control-Allow-Credentials", "true")
1010
writer.Header().Set("Access-Control-Allow-Headers", "Cache-Control,Content-Type,Content-Length,Accept-Encoding,X-LaunchDarkly-User-Agent,X-LaunchDarkly-Payload-ID,X-LaunchDarkly-Wrapper,X-LaunchDarkly-Event-Schema,X-LaunchDarkly-Tags")
11-
writer.Header().Set("Access-Control-Expose-Headers:", "Date")
11+
writer.Header().Set("Access-Control-Expose-Headers", "Date")
1212
writer.Header().Set("Access-Control-Max-Age", "300")
1313
handler.ServeHTTP(writer, request)
1414
})
@@ -20,7 +20,7 @@ func EventsCorsHeaders(handler http.Handler) http.Handler {
2020
writer.Header().Set("Access-Control-Allow-Methods", "POST,OPTIONS")
2121
writer.Header().Set("Access-Control-Allow-Credentials", "true")
2222
writer.Header().Set("Access-Control-Allow-Headers", "Accept,Content-Type,Content-Length,Accept-Encoding,X-LaunchDarkly-Event-Schema,X-LaunchDarkly-User-Agent,X-LaunchDarkly-Payload-ID,X-LaunchDarkly-Wrapper,X-LaunchDarkly-Tags")
23-
writer.Header().Set("Access-Control-Expose-Headers:", "Date")
23+
writer.Header().Set("Access-Control-Expose-Headers", "Date")
2424
writer.Header().Set("Access-Control-Max-Age", "300")
2525
handler.ServeHTTP(writer, request)
2626
})

0 commit comments

Comments
 (0)