chore: remove vendor dir, fix release action, CI for dev server UI (#502)

* remove vendor dir

* Eliminate multiple go builds

* actually run pre-commit

* set up ssh keys & remove test/build

* Remove internal pre-commit

* remove extraneous hooks file

* update build paths for ui

* Add build and test back

* eliminate some pre-commit config

* use stable go

* update golangci

* fix lint issues

* Remove ui builds from pre-commit

* Upgrade release provenance thing

* Add ui build

* correct directory

* add prettier

* fixup dirname

* set up linting

* fix eslint errors

* Add eslint config

* attempt to ignore mocks

* move ignores to end

* prettier

* rebuild

* Use working directory trick

Co-authored-by: Hosh <[email protected]>

* set working dir correctly

* remove extraneous cd

---------

Co-authored-by: Hosh <[email protected]>

Author: Mike Zorn

.github/variables/go-versions.env

@@ -0,0 +1,47 @@
+# This workflow will build a golang project
+# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-go
+
+name: dev-server UI
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main
+
+jobs:
+  ci:
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: internal/dev_server/ui
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 'lts/*'
+          cache: 'npm'
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Run lint
+        run: npm run lint
+
+      - name: Run Prettier
+        run: npm run prettier:write
+
+      - name: Run tests
+        run: npm test
+
+      - name: Run build
+        run: npm run build
+
+      - name: Check for uncommitted changes
+        run: |
+          git diff --exit-code || (echo 'Error: Uncommitted changes detected after build. Run the build locally and commit the changes.' && exit 1)

.github/workflows/dev-server-ui.yml

@@ -10,31 +10,20 @@ on:
     branches: [ "main" ]
 
 jobs:
-  go-versions:
-    uses: ./.github/workflows/go-versions.yml
-
   build:
-    needs: go-versions
     runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        go-version: ${{ fromJSON(needs.go-versions.outputs.matrix )}}
 
     steps:
     - uses: actions/checkout@v4
 
     - name: Set up Go
       uses: actions/setup-go@v4
       with:
-        go-version: ${{ matrix.go-version }}
-
-    - name: Enforce formatting / go mod tidy
-      run: |
-        ./git/hooks/pre-commit
-
-    - name: Build
-      run: go build -o ldcli
-
-    - name: Test
-      run: go test -v ./...
+        go-version: stable
+
+    - uses: actions/setup-python@v3
+    - uses: pre-commit/[email protected]
+    - name: build
+      run: go build .
+    - name: test
+      run: go test ./...

.github/workflows/go-versions.yml

@@ -35,11 +35,6 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Set up Go
-        uses: actions/setup-go@v4
-        with:
-          go-version: ${{ needs.go-versions.outputs.latest }}
-
       - uses: launchdarkly/gh-actions/actions/[email protected]
         name: 'Get Docker token'
         with:

.github/workflows/go.yml

@@ -37,11 +37,6 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Set up Go
-        uses: actions/setup-go@v4
-        with:
-          go-version: ${{ needs.go-versions.outputs.latest }}
-
       - uses: launchdarkly/gh-actions/actions/[email protected]
         name: 'Get Docker token'
         with:
@@ -88,7 +83,7 @@ jobs:
       actions: read
       id-token: write
       contents: write
-    uses: slsa-framework/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@v1.10.0
+    uses: slsa-framework/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@v2.0.0
     with:
       base64-subjects: "${{ needs.release-ldcli.outputs.hashes }}"
       upload-assets: true

.github/workflows/manual-publish.yml

@@ -1,41 +1,13 @@
 repos:
   - repo: https://github.com/golangci/golangci-lint
-    rev: v1.57.1
+    rev: v1.63.4
     hooks:
       - id: golangci-lint
         entry: golangci-lint run
-        exclude: "^(vendor/|.circleci/)"
         language: golang
         require_serial: true
         types: [go]
-  - repo: [email protected]:launchdarkly/pre-commit-go
-    rev: v0.11.0
-    hooks:
-      - id: compile-go-tests
-        entry: bin/run-script run-on-dirs "go test ./..."
-        exclude: "^vendor/|^.circleci/image/tools"
-        name: run-go-tests
-      - id: discarded-stacktrace
-        exclude: '(^vendor/|.*gen\.go)'
-      - id: go-mod-tidy
-      - id: go-mod-verify
-      - id: go-mod-vendor-no-change
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v4.6.0
     hooks:
       - id: end-of-file-fixer
-        exclude: "^vendor"
-  - repo: local
-    hooks:
-      - id: ui-tests
-        name: Run dev-server UI tests
-        entry: bash -c 'cd internal/dev_server/ui && npm test'
-        language: system
-        files: \.(jsx|tsx)$
-        pass_filenames: false
-      - id: ui-build
-        name: Build dev-server UI
-        entry: bash -c 'cd internal/dev_server/ui && npm run build'
-        language: system
-        files: \.(jsx|tsx)$
-        pass_filenames: false

.github/workflows/release-please.yml

@@ -117,7 +117,7 @@ func run(service config.Service) func(*cobra.Command, []string) error {
 				return newErr(err.Error())
 			}
 
-			fmt.Fprintf(cmd.OutOrStdout(), output+"\n")
+			fmt.Fprint(cmd.OutOrStdout(), output+"\n")
 		case viper.GetBool(SetFlag):
 			conf, err := config.New(viper.ConfigFileUsed(), os.ReadFile)
 			if err != nil {
@@ -146,7 +146,7 @@ func run(service config.Service) func(*cobra.Command, []string) error {
 				return newErr(err.Error())
 			}
 
-			fmt.Fprintf(cmd.OutOrStdout(), output+"\n")
+			fmt.Fprint(cmd.OutOrStdout(), output+"\n")
 		case viper.IsSet(UnsetFlag):
 			conf, err := config.New(viper.ConfigFileUsed(), os.ReadFile)
 			if err != nil {
@@ -166,7 +166,7 @@ func run(service config.Service) func(*cobra.Command, []string) error {
 				return newErr(err.Error())
 			}
 
-			fmt.Fprintf(cmd.OutOrStdout(), output+"\n")
+			fmt.Fprint(cmd.OutOrStdout(), output+"\n")
 		default:
 			return cmd.Help()
 		}

.pre-commit-config.yaml

@@ -56,7 +56,7 @@ func makeArchiveRequest(client resources.Client) func(*cobra.Command, []string)
 			return errors.NewError(err.Error())
 		}
 
-		fmt.Fprintf(cmd.OutOrStdout(), output+"\n")
+		fmt.Fprint(cmd.OutOrStdout(), output+"\n")
 
 		return nil
 	}

cmd/config/config.go

@@ -78,7 +78,7 @@ func runE(client resources.Client) func(*cobra.Command, []string) error {
 			return errors.NewError(err.Error())
 		}
 
-		fmt.Fprintf(cmd.OutOrStdout(), output+"\n")
+		fmt.Fprint(cmd.OutOrStdout(), output+"\n")
 
 		return nil
 	}