Skip to content

Commit 73468a0

Browse files
authored
fix: [REL-8702] fix flags get-status command (#587)
* fix * add note to readme on running locally
1 parent ec33039 commit 73468a0

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,12 @@ Additional documentation is available at https://docs.launchdarkly.com/home/gett
121121

122122
We encourage pull requests and other contributions from the community. Check out our [contributing guidelines](CONTRIBUTING.md) for instructions on how to contribute to this project.
123123

124+
### Running a local build of the CLI
125+
If you wish to test your changes locally, simply
126+
1. Clone this repo to your local machine;
127+
2. Run `make build` from the repo root;
128+
3. Run commands as usual with `./ldcli`.
129+
124130
## Verifying build provenance with the SLSA framework
125131

126132
LaunchDarkly uses the [SLSA framework](https://slsa.dev/spec/v1.0/about) (Supply-chain Levels for Software Artifacts) to help developers make their supply chain more secure by ensuring the authenticity and build integrity of our published packages. To learn more, see the [provenance guide](./PROVENANCE.md).

internal/output/plaintext_fns.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,8 @@ var SingularPlaintextOutputFn = func(r resource) string {
6565
return email.(string)
6666
case id != nil:
6767
return id.(string)
68+
case name != nil:
69+
return name.(string)
6870
default:
6971
return "cannot read resource"
7072
}

internal/output/resource_output.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ func CmdOutput(action string, outputKind string, input []byte) (string, error) {
103103
}
104104

105105
func plaintextOutput(out string, successMessage string) string {
106-
if successMessage != "" {
106+
if strings.TrimSpace(successMessage) != "" {
107107
return fmt.Sprintf("%s%s", successMessage, out)
108108
}
109109

0 commit comments

Comments
 (0)