Skip to content

Commit 9f908b2

Browse files
committed
Fix sql semantics
1 parent 4fb3eda commit 9f908b2

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

internal/dev_server/events_db/sqlite.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ func (s *Sqlite) QueryDebugSessions(ctx context.Context, limit int, offset int)
154154

155155
// Get total count for pagination info
156156
var totalCount int64
157-
countQuery := `SELECT COUNT(*) FROM debug_session`
157+
countQuery := `SELECT count(DISTINCT(debug_session_key)) FROM debug_events`
158158
err = s.database.QueryRowContext(ctx, countQuery).Scan(&totalCount)
159159
if err != nil {
160160
return nil, err

internal/dev_server/events_db/sqlite_test.go

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,9 @@ func TestDBFunctions(t *testing.T) {
4545
t.Run("WriteEvent succeeds", func(t *testing.T) {
4646
err := store.WriteEvent(ctx, debugSessionKey, "summary", []byte(testEvent))
4747
require.NoError(t, err)
48+
49+
err = store.WriteEvent(ctx, "another-session", "summary", []byte(testEvent))
50+
require.NoError(t, err)
4851
})
4952

5053
t.Run("QueryEvents with no filter", func(t *testing.T) {
@@ -110,7 +113,9 @@ func TestDBFunctions(t *testing.T) {
110113
require.NoError(t, err)
111114
err = store.WriteEvent(ctx, "session-2", "diagnostic", []byte(`{"kind":"diagnostic","data":"test"}`))
112115
require.NoError(t, err)
113-
// session-3 will have 0 events
116+
117+
err = store.WriteEvent(ctx, "session-3", "diagnostic", []byte(`{"kind":"diagnostic","data":"test"}`))
118+
require.NoError(t, err)
114119

115120
// Query first page
116121
page, err := store.QueryDebugSessions(ctx, 2, 0)
@@ -131,7 +136,7 @@ func TestDBFunctions(t *testing.T) {
131136
allPage, err := store.QueryDebugSessions(ctx, 10, 0)
132137
require.NoError(t, err)
133138
require.NotNil(t, allPage)
134-
require.Len(t, allPage.Sessions, 2)
139+
require.Len(t, allPage.Sessions, 4)
135140
require.Equal(t, int64(4), allPage.TotalCount)
136141
require.False(t, allPage.HasMore)
137142

@@ -141,9 +146,9 @@ func TestDBFunctions(t *testing.T) {
141146
allSessionKeys[session.Key] = session.EventCount
142147
}
143148

144-
require.Equal(t, int64(0), allSessionKeys["session-3"])
149+
require.Equal(t, int64(1), allSessionKeys["session-3"])
145150
require.Equal(t, int64(2), allSessionKeys["session-2"])
146-
require.Equal(t, int64(0), allSessionKeys["another-session"])
151+
require.Equal(t, int64(1), allSessionKeys["another-session"])
147152
require.Equal(t, int64(4), allSessionKeys[debugSessionKey]) // 4 events from previous tests
148153

149154
// Test pagination - second page

0 commit comments

Comments
 (0)