Skip to content

Commit a5b9ab4

Browse files
committed
remove explicit any
1 parent e7f7f9a commit a5b9ab4

File tree

5 files changed

+13
-21
lines changed

5 files changed

+13
-21
lines changed

internal/dev_server/ui/src/DebugSessionEventsPage.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { useEffect, useState } from "react";
2-
import { useParams, useNavigate } from "react-router";
2+
import { useParams } from "react-router";
33
import { apiRoute } from "./util";
44
import { ApiEventsPage, EventData, convertApiEventToEventData } from "./types";
55
import { Box, Alert } from "@launchpad-ui/core";
@@ -11,12 +11,10 @@ import { Fragment } from "react";
1111

1212
const DebugSessionEventsPage = () => {
1313
const { debugSessionKey } = useParams<{ debugSessionKey: string }>();
14-
const navigate = useNavigate();
1514
const [events, setEvents] = useState<EventData[]>([]);
1615
const [displayedEvents, setDisplayedEvents] = useState<EventData[]>([]);
1716
const [loading, setLoading] = useState<boolean>(true);
1817
const [error, setError] = useState<string | null>(null);
19-
const [totalCount, setTotalCount] = useState<number>(0);
2018

2119
const fetchEvents = async () => {
2220
if (!debugSessionKey) {
@@ -39,7 +37,6 @@ const DebugSessionEventsPage = () => {
3937
const convertedEvents = data.events?.map(convertApiEventToEventData) || [];
4038
setEvents(convertedEvents);
4139
setDisplayedEvents(convertedEvents);
42-
setTotalCount(data.total_count);
4340
} catch (err) {
4441
setError(err instanceof Error ? err.message : "An unknown error occurred");
4542
} finally {
@@ -55,7 +52,7 @@ const DebugSessionEventsPage = () => {
5552
setDisplayedEvents(events.filter(event => {
5653
let search = '';
5754

58-
const extractValues = (obj: any): string[] => {
55+
const extractValues = (obj: unknown): string[] => {
5956
if (obj === null || obj === undefined) return [];
6057
if (typeof obj === 'string' || typeof obj === 'number' || typeof obj === 'boolean') {
6158
return [String(obj)];

internal/dev_server/ui/src/DebugSessionsPage.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,6 @@ const DebugSessionsPage = () => {
4848
}
4949
};
5050

51-
const handleSessionClick = (sessionKey: string) => {
52-
navigate(`/ui/debug-sessions/${encodeURIComponent(sessionKey)}/events`);
53-
};
54-
5551
const handleDeleteSession = async (sessionKey: string) => {
5652
if (!confirm(`Are you sure you want to delete debug session "${sessionKey}" and all its events? This action cannot be undone.`)) {
5753
return;

internal/dev_server/ui/src/EventsPage.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { useEffect, useState } from "react";
22
import { apiRoute } from "./util";
33
import { EventData } from "./types";
4-
import { Icon } from "@launchpad-ui/icons";
54
import EventsTable from "./EventsTable";
65

76
type Props = {

internal/dev_server/ui/src/EventsTable.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ const clipboardLink = (linkText: string, value: string, showNotification: (messa
2727
}
2828

2929
const summaryRows = (summaryEvent: EventData, showNotification: (message: string) => void) => {
30-
let rows = [];
31-
for (const [key, value] of Object.entries((summaryEvent.data as any).features)) {
30+
const rows = [];
31+
for (const [key, value] of Object.entries(summaryEvent.data.features || {})) {
3232
const rowId = summaryEvent.id + key;
33-
const counters = (value as any).counters || [];
33+
const counters = value.counters || [];
3434

3535
for (const counter of counters) {
3636
rows.push(
@@ -84,8 +84,8 @@ const indexRows = (indexEvent: EventData, showNotification: (message: string) =>
8484
}
8585
break;
8686
}
87-
} else if ((indexEvent.data as any).user) {
88-
targetText = ((indexEvent.data as any).user.key || 'unknown') + ' user';
87+
} else if (indexEvent.data.user) {
88+
targetText = (indexEvent.data.user.key || 'unknown') + ' user';
8989
iconName = 'person-outline';
9090
}
9191
else {
@@ -104,7 +104,7 @@ const indexRows = (indexEvent: EventData, showNotification: (message: string) =>
104104
}
105105

106106
const featureRows = (featureEvent: EventData, showNotification: (message: string) => void) => {
107-
const data = featureEvent.data as any; // Type assertion for feature event
107+
const data = featureEvent.data; // Type assertion for feature event
108108
const eventText = `evaluated as ${String(data.value)}`;
109109

110110
return [
@@ -124,7 +124,7 @@ const customRows = (event: EventData, showNotification: (message: string) => voi
124124
<td>{new Date(event.timestamp).toLocaleTimeString()}</td>
125125
<td>{event.data.kind}</td>
126126
<td><Icon name="chart-histogram" size="small" /> {event.data.key || 'unknown'}</td>
127-
<td>value is {(event.data as any).metricValue}</td>
127+
<td>value is {event.data.metricValue}</td>
128128
<td>{clipboardLink('Copy to clipboard', JSON.stringify(event.data), showNotification)}</td>
129129
</tr>,
130130
];

internal/dev_server/ui/src/types.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export interface Environment {
66
export interface SummaryEventPayload {
77
kind: 'summary';
88
features: object;
9-
[key: string]: any;
9+
[key: string]: unknown;
1010
}
1111

1212
export interface FeatureEventPayload {
@@ -33,12 +33,12 @@ export interface FeatureEventPayload {
3333
export interface IndexEventPayload {
3434
kind: 'index';
3535
user?: object;
36-
[key: string]: any;
36+
[key: string]: unknown;
3737
}
3838

3939
export interface GenericEventPayload {
4040
kind: string;
41-
[key: string]: any;
41+
[key: string]: unknown;
4242
}
4343

4444
export interface EventData {
@@ -64,7 +64,7 @@ export interface ApiEvent {
6464
id: number;
6565
written_at: string;
6666
kind: string;
67-
data: any; // Raw JSON data from the API
67+
data: unknown; // Raw JSON data from the API
6868
}
6969

7070
// API EventsPage type that matches the server response

0 commit comments

Comments
 (0)