Skip to content

Commit 38b1803

Browse files
fix: Android - Remove Disk Buffering (#315)
## Summary Remove Disk buffering seems failing. Let's just delete it. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Removes OpenTelemetry disk buffering setup and its helper from `InstrumentationManager`. > > - **Observability Android SDK**: > - Remove disk buffering configuration from `createOtelRumConfig()` in `InstrumentationManager.kt` (drop `DiskBufferingConfig` setup). > - Delete unused helper `isAnySignalEnabled(options)`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 10aa487. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 6f22635 commit 38b1803

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/client/InstrumentationManager.kt

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -148,12 +148,6 @@ class InstrumentationManager(
148148

149149
private fun createOtelRumConfig(): OtelRumConfig {
150150
val config = OtelRumConfig()
151-
.setDiskBufferingConfig(
152-
DiskBufferingConfig.create(
153-
enabled = isAnySignalEnabled(options),
154-
debugEnabled = options.debug
155-
)
156-
)
157151
.setSessionConfig(SessionConfig(backgroundInactivityTimeout = options.sessionBackgroundTimeout))
158152

159153
if (options.disableErrorTracking) {
@@ -165,10 +159,6 @@ class InstrumentationManager(
165159
return config
166160
}
167161

168-
private fun isAnySignalEnabled(options: Options): Boolean {
169-
return !options.disableLogs || !options.disableTraces || !options.disableMetrics || !options.disableErrorTracking
170-
}
171-
172162
private fun configureTracerProvider(sdkTracerProviderBuilder: SdkTracerProviderBuilder): SdkTracerProviderBuilder {
173163
val primarySpanExporter = createOtlpSpanExporter()
174164
sdkTracerProviderBuilder

0 commit comments

Comments
 (0)