Skip to content

Commit 3fa3726

Browse files
committed
fix: correctly report version on webjs otel data
1 parent 2e5e96b commit 3fa3726

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

sdk/highlight-run/src/client/otel/index.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ export type BrowserTracingConfig = {
6969
environment?: string
7070
networkRecordingOptions?: NetworkRecordingOptions
7171
serviceName?: string
72+
serviceVersion?: string
7273
tracingOrigins?: boolean | (string | RegExp)[]
7374
urlBlocklist?: string[]
7475
eventNames?: EventName[]
@@ -142,6 +143,7 @@ export const setupBrowserTracing = (
142143
const resource = new Resource({
143144
[SemanticAttributes.ATTR_SERVICE_NAME]:
144145
config.serviceName ?? 'highlight-browser',
146+
[SemanticAttributes.ATTR_SERVICE_VERSION]: config.serviceVersion,
145147
'deployment.environment.name': environment,
146148
'highlight.project_id': config.projectId,
147149
[SemanticAttributes.ATTR_USER_AGENT_ORIGINAL]: navigator.userAgent,

sdk/highlight-run/src/sdk/observe.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ export class ObserveSDK implements Observe {
136136
: undefined,
137137
tracingOrigins: this._options?.tracingOrigins,
138138
serviceName: this._options?.serviceName ?? 'browser',
139+
serviceVersion: this._options?.version ?? 'browser',
139140
instrumentations: this._options?.otel?.instrumentations,
140141
eventNames: this._options?.otel?.eventNames,
141142
},

0 commit comments

Comments
 (0)