self review

Author: tanderson-ld

e2e/android/app/build.gradle.kts

@@ -28,7 +28,6 @@ android {
         }
     }
     compileOptions {
-//        isCoreLibraryDesugaringEnabled = true
         sourceCompatibility = JavaVersion.VERSION_11
         targetCompatibility = JavaVersion.VERSION_11
     }
@@ -69,8 +68,4 @@ dependencies {
     androidTestImplementation(libs.androidx.ui.test.junit4)
     debugImplementation(libs.androidx.ui.tooling)
     debugImplementation(libs.androidx.ui.test.manifest)
-
-    // This is required to use the launchdarkly-observability-android package that uses desugaring
-    // to support old Android API versions (back to 24 at time of writing this)
-//    coreLibraryDesugaring("com.android.tools:desugar_jdk_libs:2.1.5")
 }

sdk/@launchdarkly/observability-android/lib/build.gradle.kts

@@ -37,11 +37,6 @@ dependencies {
     // Use JUnit Jupiter for testing.
     testImplementation("org.junit.jupiter:junit-jupiter")
     testRuntimeOnly("org.junit.platform:junit-platform-launcher")
-
-    // This was added to support using newer types on older versions of Android.
-    // Namely use of the Duration type which requires API 26 and minSDK at
-    // time of writing is 24.
-//    coreLibraryDesugaring("com.android.tools:desugar_jdk_libs:2.1.5")
 }
 
 val releaseVersion = version.toString()
@@ -67,7 +62,6 @@ android {
         }
     }
     compileOptions {
-//        isCoreLibraryDesugaringEnabled = true
         sourceCompatibility = JavaVersion.VERSION_1_8
         targetCompatibility = JavaVersion.VERSION_1_8
     }

sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/api/Options.kt

@@ -44,4 +44,4 @@ data class Options(
     val disableMetrics: Boolean = false,
     val logAdapter: LDLogAdapter = LDTimberLogging.adapter(), // this follows the LaunchDarkly SDK's default log adapter
     val loggerName: String = "LaunchDarklyObservabilityPlugin"
-)
+)