Skip to content

Commit 6d7ca86

Browse files
committed
more review comments
1 parent 31f06ae commit 6d7ca86

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/client/InstrumentationManager.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,6 @@ class InstrumentationManager(
5858
fun recordMetric(metric: Metric) {
5959
meter.gaugeBuilder(metric.name).build()
6060
.set(metric.value, metric.attributes)
61-
62-
// TODO: O11Y-362: convert attributes to LDValue object and pass instead of LDValue.ofNull()
63-
client.trackMetric(metric.name, LDValue.ofNull(), metric.value)
6461
}
6562

6663
fun recordCount(metric: Metric) {

sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/plugin/Observability.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ class Observability : Plugin() {
3131
resourceBuilder.put("launchdarkly.application.version", it)
3232
}
3333

34-
metadata?.sdkMetadata?.name.let { sdkName ->
35-
metadata?.sdkMetadata?.version.let { sdkVersion ->
34+
metadata?.sdkMetadata?.name?.let { sdkName ->
35+
metadata.sdkMetadata?.version?.let { sdkVersion ->
3636
resourceBuilder.put("launchdarkly.sdk.version", "$sdkName/$sdkVersion")
3737
}
3838
}

0 commit comments

Comments
 (0)