refactor tests

Author: Vadman97

…hlight-run/src/client/otel/index.test.ts …ighlight-run/src/__tests__/index.test.tssdk/highlight-run/src/client/otel/index.test.ts renamed to sdk/highlight-run/src/__tests__/index.test.ts sdk/highlight-run/src/client/otel/index.test.ts renamed to sdk/highlight-run/src/__tests__/index.test.ts

@@ -1,4 +1,4 @@
-import { getCorsUrlsPattern } from './index'
+import { getCorsUrlsPattern } from '../client/otel'
 
 describe('getCorsUrlsPattern', () => {
 	it('handles `tracingOrigins: false` correctly', () => {

sdk/highlight-run/src/__tests__/index.test.tsx

@@ -1,81 +1,174 @@
-import { H } from 'highlight.run'
-import { LDClientMin, HighlightPublicInterface } from '../client'
-
-// Don't run tests for now. Need to move code from firstload to client for backend errors.
-describe.skip('should work outside of the browser in unit test', () => {
-	let highlight: HighlightPublicInterface
+import { LDClientMin } from '../client'
+import { expect, vi } from 'vitest'
+import {
+	setSessionData,
+	setSessionSecureID,
+} from '../client/utils/sessionStorage/highlightSession'
+import * as otel from '../client/otel'
+import { Highlight } from '../client'
+import { Observe } from '../api/observe'
+import { ObserveSDK } from '../sdk/observe'
+
+const sessionData = {
+	sessionSecureID: 'foo',
+	projectID: 1,
+	payloadID: 1,
+	lastPushTime: new Date().getTime(),
+	sessionStartTime: new Date().getTime(),
+}
+
+describe('should work outside of the browser in unit test', () => {
+	let highlight: Highlight
+	let observe: Observe
 
 	beforeEach(() => {
-		jest.useFakeTimers()
-		highlight = H
+		vi.useFakeTimers()
+		highlight = new Highlight({
+			organizationID: undefined,
+			sessionSecureID: '',
+		})
+		observe = new ObserveSDK({
+			otlpEndpoint: '',
+			projectId: undefined,
+			sessionSecureId: '',
+		})
+
+		setSessionSecureID('foo')
+		setSessionData(sessionData)
 	})
 
 	afterEach(() => {
-		jest.useRealTimers()
+		vi.useRealTimers()
 	})
 
 	it('should handle init', () => {
-		highlight.init('test')
+		highlight.initialize({})
 	})
 
 	it('should handle consumeError', () => {
 		const error = new Error('test error')
-		highlight.consumeError(error)
-	})
-
-	it('should handle error', () => {
-		highlight.error('test message')
+		highlight.consumeError(error, {})
 	})
 
 	it('should handle track', () => {
-		highlight.track('test message', {})
+		highlight.addProperties('test message', {})
 	})
 
 	it('should handle start', () => {
-		highlight.init('test', { manualStart: true })
-
-		highlight.start()
+		highlight.initialize({ forceNew: true })
 	})
 
 	it('should handle stop', () => {
-		highlight.stop()
+		highlight.stopRecording()
 	})
 
 	it('should handle identify', () => {
 		highlight.identify('123', {})
 	})
 
-	it('should handle getSessionURL', () => {
-		highlight.getSessionURL()
+	it('should handle getSessionURL', async () => {
+		setSessionData(sessionData)
+		highlight.initialize()
+
+		expect(await highlight.getCurrentSessionURL()).toBe(
+			'https://app.highlight.io/1/sessions/foo',
+		)
+	})
+
+	describe('startSpan', () => {
+		it('it returns the value of the callback', () =>
+			new Promise(async (done) => {
+				let tracer: any
+				await vi.waitFor(() => {
+					tracer = otel.getTracer()
+					expect(tracer).toBeDefined()
+				})
+
+				vi.spyOn(tracer, 'startActiveSpan')
+
+				const value = observe.startSpan('test', () => 'test')
+				expect(value).toBe('test')
+
+				expect(tracer.startActiveSpan).toHaveBeenCalledWith(
+					'test',
+					expect.any(Function),
+				)
+
+				done(true)
+			}))
 	})
 
-	it('should handle getSessionDetails', () => {
-		highlight.getSessionDetails()
+	describe('startManualSpan', () => {
+		it('it returns the value of the callback', () =>
+			new Promise(async (done) => {
+				let tracer: any
+				await vi.waitFor(() => {
+					tracer = otel.getTracer()
+					expect(tracer).toBeDefined()
+				})
+
+				vi.spyOn(tracer, 'startActiveSpan')
+
+				const value = observe.startManualSpan('test', (span) => {
+					span.end()
+					return 'test'
+				})
+				expect(value).toBe('test')
+
+				expect(tracer.startActiveSpan).toHaveBeenCalledWith(
+					'test',
+					expect.any(Function),
+				)
+
+				done(true)
+			}))
 	})
 })
 
+const sleep = (ms: number) => {
+	const promise = new Promise((resolve) => setTimeout(resolve, ms))
+	vi.advanceTimersByTime(ms)
+	return promise
+}
+
 describe('LD integration', () => {
-	let highlight: HighlightPublicInterface
+	let highlight: Highlight
 
 	beforeEach(() => {
-		jest.useFakeTimers()
-		highlight = H
+		vi.useFakeTimers()
+		highlight = new Highlight({
+			organizationID: '',
+			sessionSecureID: '',
+		})
 	})
 
 	afterEach(() => {
-		jest.useRealTimers()
+		vi.useRealTimers()
 	})
 
 	it('should handle register', () => {
+		const worker = (globalThis.Worker as unknown as typeof Worker).prototype
+		worker.postMessage = vi.fn(
+			(_message: unknown, _options?: unknown) => null,
+		)
+
 		const client: LDClientMin = {
-			track: jest.fn(),
-			identify: jest.fn(),
-			addHook: jest.fn(),
+			track: vi.fn(),
+			identify: vi.fn(),
+			addHook: vi.fn(),
 		}
 		highlight.registerLD(client)
 
-		expect(client.addHook).toHaveBeenCalled()
+		expect(client.addHook).not.toHaveBeenCalled()
 		expect(client.identify).not.toHaveBeenCalled()
 		expect(client.track).not.toHaveBeenCalled()
+		expect(worker.postMessage).not.toHaveBeenCalled()
+
+		highlight.identify('123', {})
+		highlight.addProperties('test', {})
+		// noop for launchdarkly
+		expect(client.identify).not.toHaveBeenCalled()
+		expect(client.track).toHaveBeenCalled()
+		expect(worker.postMessage).toHaveBeenCalled()
 	})
 })

…ers/network-listener/utils/utils.test.ts …ighlight-run/src/__tests__/utils.test.tssdk/highlight-run/src/client/listeners/network-listener/utils/utils.test.ts renamed to sdk/highlight-run/src/__tests__/utils.test.ts sdk/highlight-run/src/client/listeners/network-listener/utils/utils.test.ts renamed to sdk/highlight-run/src/__tests__/utils.test.ts

@@ -2,7 +2,7 @@ import {
 	normalizeUrl,
 	shouldNetworkRequestBeRecorded,
 	shouldNetworkRequestBeTraced,
-} from './utils'
+} from '../client/listeners/network-listener/utils/utils'
 
 describe('normalizeUrl', () => {
 	vi.stubGlobal('location', {