Skip to content

Commit 9ac801b

Browse files
authored
fix manual publish step not publishing highlight.run (#53)
## Summary With no changesets present, manual publish would do nothing for the highlight SDKs. <img width="1193" alt="Screenshot 2025-05-16 at 19 01 48" src="https://github.com/user-attachments/assets/f303c0d2-c7fc-4b15-94f4-b51aebe2c5d0" /> ## How did you test this change? Corrected behavior tested by [kicking off](https://github.com/launchdarkly/observability-sdk/actions/runs/15079659237) manual publish. ## Are there any deployment considerations? no ## Does this work require review from our design team? no
1 parent 0e87afd commit 9ac801b

File tree

2 files changed

+3
-11
lines changed

2 files changed

+3
-11
lines changed

.github/workflows/manual-publish.yml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,7 @@ jobs:
6161
- name: Publish highlight npm packages
6262
if: ${{ inputs.release_highlight == true }}
6363
id: changesets-publish
64-
uses: changesets/action@v1
65-
with:
66-
publish: yarn publish:highlight
67-
env:
68-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
69-
NPM_TOKEN: ${{ secrets.NPM_TOKEN_HIGHLIGHT_RUN }}
70-
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN_HIGHLIGHT_RUN }}
64+
run: yarn publish:highlight
7165

7266
- uses: launchdarkly/gh-actions/actions/[email protected]
7367
if: ${{ inputs.release_launchdarkly == true }}
@@ -85,8 +79,7 @@ jobs:
8579
- name: Publish
8680
if: ${{ inputs.release_launchdarkly == true }}
8781
shell: bash
88-
run: |
89-
./scripts/publish-npm.sh
82+
run: ./scripts/publish-npm.sh
9083
env:
9184
LD_RELEASE_IS_PRERELEASE: ${{ inputs.prerelease }}
9285
LD_RELEASE_IS_DRYRUN: ${{ inputs.dry-run }}

.github/workflows/turbo.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,7 @@ jobs:
8585
- name: Publish
8686
if: github.ref == 'refs/heads/main'
8787
shell: bash
88-
run: |
89-
./scripts/publish-npm.sh
88+
run: ./scripts/publish-npm.sh
9089
env:
9190
LD_RELEASE_IS_PRERELEASE: ${{ inputs.prerelease }}
9291
LD_RELEASE_IS_DRYRUN: ${{ inputs.dry-run }}

0 commit comments

Comments
 (0)