Skip to content

Commit b59fbd4

Browse files
fix: Remove 3 dependencies from MAUI Android (3 aar files) (#449)
## Summary Remove 3 dependencies from MAUI Android (3 aar files) after cleaning Android. Tested on 2 apps and released as 0.5.3 nuget ## How did you test this change? <!-- Frontend - Leave a screencast or a screenshot to visually describe the changes. --> ## Are there any deployment considerations? <!-- Backend - Do we need to consider migrations or backfilling data? --> <!-- CURSOR_SUMMARY --> --- > [!NOTE] > <sup>[Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) is generating a summary for commit bbc5f43. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 5990ce9 commit b59fbd4

File tree

3 files changed

+10
-16
lines changed

3 files changed

+10
-16
lines changed

sdk/@launchdarkly/mobile-dotnet/android/native/LDObserve/build.gradle.kts

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,11 @@ configurations {
3737
}
3838

3939
dependencies {
40-
4140
implementation("androidx.core:core-ktx:1.15.0")
4241
"copyDependencies"("androidx.core:core-ktx:1.15.0")
4342

4443
// Copy dependencies for binding library
4544
// Uncomment line below and replace dependency.name.goes.here with your dependency
46-
47-
4845
implementation("com.launchdarkly:launchdarkly-android-client-sdk:5.11.0")
4946
"copyDependencies"("com.launchdarkly:launchdarkly-android-client-sdk:5.11.0")
5047

@@ -55,6 +52,7 @@ dependencies {
5552
implementation("com.launchdarkly:launchdarkly-observability-android:0.0.0-local")
5653

5754
// TODO: revise these versions to be as old as usable for compatibility
55+
// OpenTelemetry JARs copied here are filtered for NuGet in observability/LDObservability.Fat.csproj (autoconfigure vs autoconfigure-spi).
5856
implementation("io.opentelemetry:opentelemetry-api:1.51.0")
5957
"copyDependencies"("io.opentelemetry:opentelemetry-api:1.51.0")
6058

@@ -73,16 +71,10 @@ dependencies {
7371
implementation("io.opentelemetry:opentelemetry-sdk-logs:1.51.0")
7472
"copyDependencies"("io.opentelemetry:opentelemetry-sdk-logs:1.51.0")
7573

76-
7774
// TODO: Evaluate risks associated with incubator APIs
7875
implementation("io.opentelemetry:opentelemetry-api-incubator:1.51.0-alpha")
7976
"copyDependencies"("io.opentelemetry:opentelemetry-api-incubator:1.51.0-alpha")
8077

81-
// Testing exporters for telemetry inspection
82-
implementation("io.opentelemetry:opentelemetry-sdk-testing:1.51.0")
83-
"copyDependencies"("io.opentelemetry:opentelemetry-sdk-testing:1.51.0")
84-
85-
8678
// OTEL Android
8779
implementation("io.opentelemetry.android:core:0.11.0-alpha")
8880
"copyDependencies"("io.opentelemetry.android:core:0.11.0-alpha")
@@ -98,12 +90,8 @@ dependencies {
9890
implementation("io.opentelemetry.android.instrumentation:activity:0.11.0-alpha")
9991
"copyDependencies"("io.opentelemetry.android.instrumentation:activity:0.11.0-alpha")
10092

101-
10293
implementation("io.opentelemetry.android:android-agent:0.11.0-alpha")
10394
"copyDependencies"("io.opentelemetry.android:android-agent:0.11.0-alpha")
104-
105-
// implementation("io.opentelemetry.android:opentelemetry-android-bom:0.11.0-alpha")
106-
// "copyDependencies"("io.opentelemetry.android:opentelemetry-android-bom:0.11.0-alpha")
10795
}
10896

10997
// Copy dependencies for binding library

sdk/@launchdarkly/mobile-dotnet/observability/Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project>
22
<PropertyGroup>
33
<PackageId>LaunchDarkly.SessionReplay</PackageId>
4-
<Version>0.5.2</Version>
4+
<Version>0.5.3</Version>
55
<UseLocalClientSdk>false</UseLocalClientSdk>
66
<Authors>LaunchDarkly</Authors>
77
<Owners>LaunchDarkly</Owners>

sdk/@launchdarkly/mobile-dotnet/observability/LDObservability.Fat.csproj

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,14 @@
9797
<None Include="..\android\native\LDObserve\bin\Release\net9.0-android\outputs\deps\launchdarkly-android-client-sdk-*.aar" Pack="true" PackagePath="runtimes/android/native/" />
9898
<None Include="..\android\native\LDObserve\bin\Release\net9.0-android\outputs\deps\lib-release.aar" Pack="true" PackagePath="runtimes/android/native/" />
9999

100-
<!-- Specific jars -->
101-
<None Include="..\android\native\LDObserve\bin\Release\net9.0-android\outputs\deps\opentelemetry-*.jar" Pack="true" PackagePath="runtimes/android/native/" />
100+
<!-- Exclude all opentelemetry-sdk-extension-autoconfigure-*.jar, then re-include *-spi-* only: the main
101+
autoconfigure jar must not be packaged, but autoconfigure-spi must. A single exclude cannot use
102+
autoconfigure-* without dropping SPI; autoconfigure-1* was tied to OTel 1.x and broke after a 2.x bump. -->
103+
<None Include="..\android\native\LDObserve\bin\Release\net9.0-android\outputs\deps\opentelemetry-*.jar"
104+
Exclude="..\android\native\LDObserve\bin\Release\net9.0-android\outputs\deps\opentelemetry-sdk-extension-incubator-*.jar;..\android\native\LDObserve\bin\Release\net9.0-android\outputs\deps\opentelemetry-sdk-extension-autoconfigure-*.jar"
105+
Pack="true" PackagePath="runtimes/android/native/" />
106+
<None Include="..\android\native\LDObserve\bin\Release\net9.0-android\outputs\deps\opentelemetry-sdk-extension-autoconfigure-spi-*.jar"
107+
Pack="true" PackagePath="runtimes/android/native/" />
102108
<None Include="..\android\native\LDObserve\bin\Release\net9.0-android\outputs\deps\jackson-*.jar" Pack="true" PackagePath="runtimes/android/native/" />
103109
<None Include="..\android\native\LDObserve\bin\Release\net9.0-android\outputs\deps\launchdarkly-*.jar" Pack="true" PackagePath="runtimes/android/native/" />
104110
<None Include="..\android\native\LDObserve\bin\Release\net9.0-android\outputs\deps\okhttp-*.jar" Pack="true" PackagePath="runtimes/android/native/" />

0 commit comments

Comments
 (0)