Commit f1a2c74
authored
fix: correctly report version on webjs otel data (#278)
## Summary
Exceptions (and other data) reported via OTel were missing the service
version.
## How did you test this change?
local deploy
<img width="2650" height="1341" alt="image"
src="https://github.com/user-attachments/assets/20c66bdc-4fd3-4e80-93ba-b1782aadc339"
/>
## Are there any deployment considerations?
<!--
Backend - Do we need to consider migrations or backfilling data?
-->
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> Propagates `version` to OTEL as `serviceVersion` and sets
`service.version` resource attribute; updates e2e configs to supply
version.
>
> - **SDK (OTEL)**:
> - Extend `BrowserTracingConfig` with `serviceVersion` and set
`Resource` attribute `service.version` via `ATTR_SERVICE_VERSION` in
`sdk/highlight-run/src/client/otel/index.ts`.
> - Pass through `version` as `serviceVersion` from `ObserveSDK` options
in `sdk/highlight-run/src/sdk/observe.ts`.
> - **E2E**:
> - Provide `version: 'my-version'` in `observabilitySettings` and
`sessionReplaySettings` in `e2e/react-router/src/ldclientLazy.tsx`.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
f1a0498. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent fb9faeb commit f1a2c74
File tree
3 files changed
+5
-0
lines changed- e2e/react-router/src
- sdk/highlight-run/src
- client/otel
- sdk
3 files changed
+5
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| 25 | + | |
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| 72 | + | |
72 | 73 | | |
73 | 74 | | |
74 | 75 | | |
| |||
142 | 143 | | |
143 | 144 | | |
144 | 145 | | |
| 146 | + | |
145 | 147 | | |
146 | 148 | | |
147 | 149 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
| 139 | + | |
139 | 140 | | |
140 | 141 | | |
141 | 142 | | |
| |||
0 commit comments