feat: recursive mask collection #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* andrey/nonstandard-views: Attached dialog sample space use Canvas for certain types of windows consolidate in one view sample of adding floating views add floating button test: Add UI and logic to evaluate boolean flags (#305)
…ed-mask2 * andrey/do-not-send-duplicate-windows: Unit tests Volatile address feedback Fix feedback Recycle bitmap early fix size bug no message
* andrey/nonstandard-views: address feadback Attached dialog sample space use Canvas for certain types of windows consolidate in one view sample of adding floating views add floating button feat: Android SR Do not send duplicate screens (#304) # Conflicts: # e2e/android/app/src/main/java/com/example/androidobservability/masking/XMLMaskingActivity.kt # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/capture/CaptureSource.kt # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/capture/WindowEntry.kt # sdk/@launchdarkly/observability-android/lib/src/test/kotlin/com/launchdarkly/observability/replay/capture/TiledSignatureManagerTest.kt
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...y-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/MaskCollector.kt
Show resolved
Hide resolved
* main: feat: support non-standard windows added by WindowManager (#306)
agrognetti
requested changes
Dec 3, 2025
...y-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/capture/CaptureSource.kt
Outdated
Show resolved
Hide resolved
...y-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/capture/CaptureSource.kt
Outdated
Show resolved
Hide resolved
...android/lib/src/main/kotlin/com/launchdarkly/observability/replay/capture/WindowInspector.kt
Outdated
Show resolved
Hide resolved
...ndroid/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/NativeMaskTarget.kt
Outdated
Show resolved
Hide resolved
...d/lib/src/main/kotlin/com/launchdarkly/observability/replay/utils/ViewGraphicsExtenstions.kt
Outdated
Show resolved
Hide resolved
...ndroid/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/NativeMaskTarget.kt
Show resolved
Hide resolved
...ndroid/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/NativeMaskTarget.kt
Show resolved
Hide resolved
...ndroid/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/NativeMaskTarget.kt
Show resolved
Hide resolved
agrognetti
approved these changes
Dec 3, 2025
Merged
abelonogov-ld
added a commit
that referenced
this pull request
Dec 3, 2025
* main: feat: recursive mask collection (#308) # Conflicts: # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/capture/CaptureSource.kt # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/ComposeMaskTarget.kt # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/Mask.kt # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/MaskCollector.kt # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/MaskMatcher.kt # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/NativeMaskTarget.kt
abelonogov-ld
added a commit
that referenced
this pull request
Dec 4, 2025
* main: (85 commits) doc: Add using ldMask in readme. (#311) chore: release main (#312) feat: take transformed coordinates, which are more precise in animation (#309) chore: release main (#307) fix(SEC-7530): update react-server-dom-webpack to 19.0.1 (#310) feat: recursive mask collection (#308) feat: support non-standard windows added by WindowManager (#306) feat: Android SR Do not send duplicate screens (#304) test: Add UI and logic to evaluate boolean flags (#305) chore: release main (#303) feat: Android Dialog Capture (#302) chore: Update Android Test main screen (#301) chore: release main (#300) feat: XML Views Automasking options (#299) fix: missed imports (#298) chore: release main (#297) feat: Support ldMask() for Native and Compose views. (#295) chore: release main (#296) fix: tweaks Android InteractionDetector to delegate additional defaul… (#294) chore: release main (#293) ... # Conflicts: # e2e/react-router/src/ldclientLazy.tsx # e2e/react-router/src/routes/root.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How did you test this change?
Are there any deployment considerations?
Note
Switches to a recursive mask collection using a new Mask model, updates capture to draw masks across windows, and improves window inspection on Q+.
Maskmodel and new recursiveMaskCollectorthat traverses native and Compose (AbstractComposeView) hierarchies; filters internalAndroidComposeView.ComposeMaskTarget/NativeMaskTargetto returnMask; adds stronger password detection viaInputTypechecks.SensitiveAreasCollectorandmaskRectAPI in favor ofmask().CaptureSourcenow collectsMasks and draws them; bases capture on lowest visible window and composites additional windows with translations.createBitmap), adds@RequiresApitopixelCopy, simplifiescanvasDraw.WindowInspectoruses Q+WindowInspector.getGlobalWindowViews()and a newlocationOnScreen()util for coordinates; cleans up root view reflection.View.locationOnScreen()extension.Written by Cursor Bugbot for commit 1180d8b. This will update automatically on new commits. Configure here.