chore: Fix existing RRwebGraphQLReplayLogExporterTest tests #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...b/src/test/kotlin/com/launchdarkly/observability/replay/RRwebGraphQLReplayLogExporterTest.kt
Outdated
Show resolved
Hide resolved
Contributor
|
Why were these tests working before, but now they’ve stopped working? |
...b/src/test/kotlin/com/launchdarkly/observability/replay/RRwebGraphQLReplayLogExporterTest.kt
Show resolved
Hide resolved
agrognetti
approved these changes
Dec 15, 2025
...b/src/test/kotlin/com/launchdarkly/observability/replay/RRwebGraphQLReplayLogExporterTest.kt
Show resolved
Hide resolved
Contributor
Author
Just Mistery. |
abelonogov-ld
added a commit
that referenced
this pull request
Dec 16, 2025
* main: chore: Fix existing RRwebGraphQLReplayLogExporterTest tests (#321) feat: sanitize URLs + semantic conventions for header attributes (#317) refactor: introduce granular ObservabilityOptions (#323) refactor: OY11-846 - Add Session Replay plugin (#313) # Conflicts: # sdk/@launchdarkly/observability-android/lib/src/test/kotlin/com/launchdarkly/observability/replay/RRwebGraphQLReplayLogExporterTest.kt
abelonogov-ld
added a commit
that referenced
this pull request
Dec 16, 2025
* main: feat: Limit accumulating canvas buffer (#322) chore: Fix existing RRwebGraphQLReplayLogExporterTest tests (#321) feat: sanitize URLs + semantic conventions for header attributes (#317) refactor: introduce granular ObservabilityOptions (#323) refactor: OY11-846 - Add Session Replay plugin (#313) chore: upgrade react-server-dom-webpack to 19.0.3 (#320) chore: release main (#319) feat: enhance Web Vitals telemetry with semantic attributes (#316) chore: release main (#318) fix: Android - Remove Disk Buffering (#315) chore: readme update with real examples (#314)
abelonogov-ld
added a commit
that referenced
this pull request
Jan 13, 2026
* main: (29 commits) chore: release main (#344) feat: Android double masking with frame drop (#342) chore: update LaunchDarkly SDK dependencies (#336) chore: Android SR - cleanup privacy settings (#341) chore: release main (#340) feat: Added privacy options: maskViews, maskXMLViewIds, maskImageViews (#339) test: O11Y-908 - Add Android CI workflows (#337) chore: release main (#335) feat: publish umd for broser environments (#334) chore: release main (#333) feat: Pause and resume replay capture on app background/foreground (#329) fix: Fix compose coordinate offset. (#331) chore: release main (#324) fix(highlight.run): correct privacy masking for empty strings (#332) feat: Android SR Identify support (#330) feat: Gzip compression for Graphql request body (#328) docs: Update readme with options refactor (#326) feat: Graphql client memory optimization (#325) feat: Limit accumulating canvas buffer (#322) chore: Fix existing RRwebGraphQLReplayLogExporterTest tests (#321) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RRwebGraphQLReplayLogExporterTest tests started failed unexpectedly, after inspection turns out there were testing what is not done yet.
Some are fixed and 2 got disabled.
Note
Disables two unsupported tests and updates remaining RRwebGraphQLReplayLogExporter tests to relax event/count expectations and simplify event assertions.
sdk/@launchdarkly/.../RRwebGraphQLReplayLogExporterTest.kt):export should send full capture for first session and incremental for subsequent captures in same session(feature not implemented).export should stop processing on first failure and not process remaining captures(exception handling not implemented).coVerifycounts from multiple toexactly = 1forinitializeReplaySession,identifyReplaySession, andpushPayloadin several tests (e.g., dimension-change, mixed valid/invalid, multiple captures same session).capturedEventsListsand simplified assertions; removed strict event-size checks inverifyFullCaptureEventsandverifyIncrementalCaptureEvents(now verify presence/types only).@Disabledimport and minor test refactors/renames.Written by Cursor Bugbot for commit 8cf49c3. This will update automatically on new commits. Configure here.