Added default values and updated prop names

Author: ctawiah

ldai/client.py

@@ -191,10 +191,15 @@ class LDAIAgentConfig:
 
     Combines agent key with its specific default configuration and variables.
     """
-    agent_key: str
-    default_config: LDAIAgentDefaults
+    key: str
+    default_value: Optional[LDAIAgentDefaults] = None
     variables: Optional[Dict[str, Any]] = None
 
+    def __post_init__(self):
+        """Set default value if not provided."""
+        if self.default_value is None:
+            self.default_value = LDAIAgentDefaults(enabled=False)
+
 
 # Type alias for multiple agents
 LDAIAgents = Dict[str, LDAIAgent]
@@ -237,7 +242,7 @@ def agent(
         self,
         key: str,
         context: Context,
-        default_value: LDAIAgentDefaults,
+        default_value: Optional[LDAIAgentDefaults] = None,
         variables: Optional[Dict[str, Any]] = None,
     ) -> LDAIAgent:
         """
@@ -248,6 +253,7 @@ def agent(
 
         Example::
 
+            # With explicit default configuration
             agent = client.agent(
                 'research_agent',
                 context,
@@ -259,6 +265,9 @@ def agent(
                 {'topic': 'climate change'}
             )
 
+            # Or with optional default (defaults to {enabled: False})
+            agent = client.agent('research_agent', context, variables={'topic': 'climate change'})
+
             if agent.enabled:
                 research_result = agent.instructions  # Interpolated instructions
                 agent.tracker.track_success()
@@ -269,6 +278,10 @@ def agent(
         :param variables: Additional variables for template interpolation in instructions.
         :return: Configured LDAIAgent instance.
         """
+        # Set default value if not provided
+        if default_value is None:
+            default_value = LDAIAgentDefaults(enabled=False)
+
         # Track single agent usage
         self._client.track(
             "$ld:ai:agent:function:single",
@@ -295,16 +308,16 @@ def agents(
 
             agents = client.agents([
                 LDAIAgentConfig(
-                    agent_key='research_agent',
-                    default_config=LDAIAgentDefaults(
+                    key='research_agent',
+                    default_value=LDAIAgentDefaults(
                         enabled=True,
                         instructions='You are a research assistant.'
                     ),
                     variables={'topic': 'climate change'}
                 ),
                 LDAIAgentConfig(
-                    agent_key='writing_agent',
-                    default_config=LDAIAgentDefaults(
+                    key='writing_agent',
+                    default_value=LDAIAgentDefaults(
                         enabled=True,
                         instructions='You are a writing assistant.'
                     ),
@@ -332,12 +345,12 @@ def agents(
 
         for config in agent_configs:
             agent = self.__evaluate_agent(
-                config.agent_key,
+                config.key,
                 context,
-                config.default_config,
+                config.default_value,
                 config.variables
             )
-            result[config.agent_key] = agent
+            result[config.key] = agent
 
         return result
 

ldai/testing/test_agents.py

@@ -167,17 +167,17 @@ def test_agents_method_with_configs(ldai_client: LDAIClient):
 
     agent_configs = [
         LDAIAgentConfig(
-            agent_key='customer-support-agent',
-            default_config=LDAIAgentDefaults(
+            key='customer-support-agent',
+            default_value=LDAIAgentDefaults(
                 enabled=False,
                 model=ModelConfig('fallback-model'),
                 instructions="Default support"
             ),
             variables={'company_name': 'Acme Corp'}
         ),
         LDAIAgentConfig(
-            agent_key='sales-assistant',
-            default_config=LDAIAgentDefaults(
+            key='sales-assistant',
+            default_value=LDAIAgentDefaults(
                 enabled=False,
                 model=ModelConfig('fallback-model'),
                 instructions="Default sales"
@@ -208,16 +208,16 @@ def test_agents_method_different_variables_per_agent(ldai_client: LDAIClient):
 
     agent_configs = [
         LDAIAgentConfig(
-            agent_key='personalized-agent',
-            default_config=LDAIAgentDefaults(
+            key='personalized-agent',
+            default_value=LDAIAgentDefaults(
                 enabled=True,
                 instructions="Default personal"
             ),
             variables={}  # Will use context only
         ),
         LDAIAgentConfig(
-            agent_key='customer-support-agent',
-            default_config=LDAIAgentDefaults(
+            key='customer-support-agent',
+            default_value=LDAIAgentDefaults(
                 enabled=True,
                 instructions="Default support"
             ),
@@ -242,8 +242,8 @@ def test_agents_with_multi_context_interpolation(ldai_client: LDAIClient):
 
     agent_configs = [
         LDAIAgentConfig(
-            agent_key='multi-context-agent',
-            default_config=LDAIAgentDefaults(
+            key='multi-context-agent',
+            default_value=LDAIAgentDefaults(
                 enabled=True,
                 instructions="Default multi-context"
             ),
@@ -275,8 +275,8 @@ def test_disabled_agent_multiple_method(ldai_client: LDAIClient):
 
     agent_configs = [
         LDAIAgentConfig(
-            agent_key='disabled-agent',
-            default_config=LDAIAgentDefaults(enabled=True, instructions="Default"),
+            key='disabled-agent',
+            default_value=LDAIAgentDefaults(enabled=True, instructions="Default"),
             variables={}
         )
     ]
@@ -354,13 +354,13 @@ def test_agent_tracking_calls(ldai_client: LDAIClient):
     # Test multiple agents tracking
     agent_configs = [
         LDAIAgentConfig(
-            agent_key='customer-support-agent',
-            default_config=defaults,
+            key='customer-support-agent',
+            default_value=defaults,
             variables={}
         ),
         LDAIAgentConfig(
-            agent_key='sales-assistant',
-            default_config=defaults,
+            key='sales-assistant',
+            default_value=defaults,
             variables={}
         )
     ]
@@ -397,24 +397,70 @@ def test_backwards_compatibility_with_config(ldai_client: LDAIClient):
 def test_agent_config_dataclass():
     """Test the LDAIAgentConfig dataclass functionality."""
     config = LDAIAgentConfig(
-        agent_key='test-agent',
-        default_config=LDAIAgentDefaults(
+        key='test-agent',
+        default_value=LDAIAgentDefaults(
             enabled=True,
             instructions="Test instructions"
         ),
         variables={'key': 'value'}
     )
 
-    assert config.agent_key == 'test-agent'
-    assert config.default_config.enabled is True
-    assert config.default_config.instructions == "Test instructions"
+    assert config.key == 'test-agent'
+    assert config.default_value.enabled is True
+    assert config.default_value.instructions == "Test instructions"
     assert config.variables == {'key': 'value'}
 
     # Test with no variables
     config_no_vars = LDAIAgentConfig(
-        agent_key='test-agent-2',
-        default_config=LDAIAgentDefaults(enabled=False)
+        key='test-agent-2',
+        default_value=LDAIAgentDefaults(enabled=False)
     )
 
-    assert config_no_vars.agent_key == 'test-agent-2'
+    assert config_no_vars.key == 'test-agent-2'
     assert config_no_vars.variables is None
+
+
+def test_agent_config_optional_default_value():
+    """Test that LDAIAgentConfig defaults to {enabled: False} when default_value is not provided."""
+    config = LDAIAgentConfig(key='test-agent')
+    
+    assert config.key == 'test-agent'
+    assert config.default_value is not None
+    assert config.default_value.enabled is False
+    assert config.variables is None
+
+
+def test_single_agent_optional_default_value(ldai_client: LDAIClient):
+    """Test the single agent() method with optional default_value."""
+    context = Context.create('user-key')
+    
+    # Should work with no default_value provided (defaults to {enabled: False})
+    agent = ldai_client.agent('non-existent-agent', context)
+    
+    assert agent.enabled is False  # Should default to False
+    assert agent.tracker is not None
+
+
+def test_agents_method_with_optional_defaults(ldai_client: LDAIClient):
+    """Test agents method with optional default_value configurations."""
+    context = Context.create('user-key')
+
+    agent_configs = [
+        LDAIAgentConfig(key='customer-support-agent'),  # No default_value
+        LDAIAgentConfig(
+            key='sales-assistant',
+            default_value=LDAIAgentDefaults(enabled=True, instructions="Custom sales assistant")
+        )
+    ]
+
+    agents = ldai_client.agents(agent_configs, context)
+
+    assert len(agents) == 2
+    
+    # First agent should use default {enabled: False} from auto-generated default_value
+    support_agent = agents['customer-support-agent']
+    assert support_agent.enabled is True  # From flag configuration
+    
+    # Second agent should use custom default
+    sales_agent = agents['sales-assistant']
+    assert sales_agent.enabled is True