Skip to content

Commit 6bd35ee

Browse files
committed
fix: Remove deprecated track generation event
1 parent fc9da97 commit 6bd35ee

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

ldai/testing/test_tracker.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,6 @@ def test_tracks_bedrock_metrics(client: LDClient):
149149
tracker.track_bedrock_converse_metrics(bedrock_result)
150150

151151
calls = [
152-
call('$ld:ai:generation', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1),
153152
call('$ld:ai:generation:success', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1),
154153
call('$ld:ai:duration:total', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 50),
155154
call('$ld:ai:tokens:total', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 330),
@@ -182,7 +181,6 @@ def test_tracks_bedrock_metrics_with_error(client: LDClient):
182181
tracker.track_bedrock_converse_metrics(bedrock_result)
183182

184183
calls = [
185-
call('$ld:ai:generation', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1),
186184
call('$ld:ai:generation:error', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1),
187185
call('$ld:ai:duration:total', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 50),
188186
call('$ld:ai:tokens:total', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 330),
@@ -216,7 +214,6 @@ def to_dict(self):
216214
tracker.track_openai_metrics(lambda: Result())
217215

218216
calls = [
219-
call('$ld:ai:generation', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1),
220217
call('$ld:ai:generation:success', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1),
221218
call('$ld:ai:tokens:total', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 330),
222219
call('$ld:ai:tokens:input', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 220),
@@ -242,7 +239,6 @@ def raise_exception():
242239
pass
243240

244241
calls = [
245-
call('$ld:ai:generation', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1),
246242
call('$ld:ai:generation:error', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1),
247243
]
248244

@@ -279,7 +275,6 @@ def test_tracks_success(client: LDClient):
279275
tracker.track_success()
280276

281277
calls = [
282-
call('$ld:ai:generation', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1),
283278
call('$ld:ai:generation:success', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1),
284279
]
285280

@@ -294,7 +289,6 @@ def test_tracks_error(client: LDClient):
294289
tracker.track_error()
295290

296291
calls = [
297-
call('$ld:ai:generation', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1),
298292
call('$ld:ai:generation:error', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1),
299293
]
300294

@@ -310,9 +304,7 @@ def test_error_overwrites_success(client: LDClient):
310304
tracker.track_error()
311305

312306
calls = [
313-
call('$ld:ai:generation', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1),
314307
call('$ld:ai:generation:success', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1),
315-
call('$ld:ai:generation', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1),
316308
call('$ld:ai:generation:error', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1),
317309
]
318310

ldai/tracker.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -168,9 +168,6 @@ def track_success(self) -> None:
168168
Track a successful AI generation.
169169
"""
170170
self._summary._success = True
171-
self._ld_client.track(
172-
'$ld:ai:generation', self._context, self.__get_track_data(), 1
173-
)
174171
self._ld_client.track(
175172
'$ld:ai:generation:success', self._context, self.__get_track_data(), 1
176173
)
@@ -180,9 +177,6 @@ def track_error(self) -> None:
180177
Track an unsuccessful AI generation attempt.
181178
"""
182179
self._summary._success = False
183-
self._ld_client.track(
184-
'$ld:ai:generation', self._context, self.__get_track_data(), 1
185-
)
186180
self._ld_client.track(
187181
'$ld:ai:generation:error', self._context, self.__get_track_data(), 1
188182
)

0 commit comments

Comments
 (0)