Skip to content

Commit 938c610

Browse files
committed
Merge branch 'main' into kfreeman/REL-8497/ai-tracker-model-provider
2 parents ef2147d + ed02047 commit 938c610

File tree

2 files changed

+1
-55
lines changed

2 files changed

+1
-55
lines changed

ldai/testing/test_tracker.py

Lines changed: 1 addition & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -180,12 +180,6 @@ def test_tracks_bedrock_metrics(client: LDClient):
180180
tracker.track_bedrock_converse_metrics(bedrock_result)
181181

182182
calls = [
183-
call(
184-
"$ld:ai:generation",
185-
context,
186-
{"variationKey": "variation-key", "configKey": "config-key", "version": 3, "modelName": "fakeModel", "providerName": "fakeProvider"},
187-
1,
188-
),
189183
call(
190184
"$ld:ai:generation:success",
191185
context,
@@ -243,12 +237,6 @@ def test_tracks_bedrock_metrics_with_error(client: LDClient):
243237
tracker.track_bedrock_converse_metrics(bedrock_result)
244238

245239
calls = [
246-
call(
247-
"$ld:ai:generation",
248-
context,
249-
{"variationKey": "variation-key", "configKey": "config-key", "version": 3, "modelName": "fakeModel", "providerName": "fakeProvider"},
250-
1,
251-
),
252240
call(
253241
"$ld:ai:generation:error",
254242
context,
@@ -307,12 +295,6 @@ def to_dict(self):
307295
tracker.track_openai_metrics(lambda: Result())
308296

309297
calls = [
310-
call(
311-
"$ld:ai:generation",
312-
context,
313-
{"variationKey": "variation-key", "configKey": "config-key", "version": 3, "modelName": "fakeModel", "providerName": "fakeProvider"},
314-
1,
315-
),
316298
call(
317299
"$ld:ai:generation:success",
318300
context,
@@ -358,12 +340,6 @@ def raise_exception():
358340
pass
359341

360342
calls = [
361-
call(
362-
"$ld:ai:generation",
363-
context,
364-
{"variationKey": "variation-key", "configKey": "config-key", "version": 3, "modelName": "fakeModel", "providerName": "fakeProvider"},
365-
1,
366-
),
367343
call(
368344
"$ld:ai:generation:error",
369345
context,
@@ -405,12 +381,6 @@ def test_tracks_success(client: LDClient):
405381
tracker.track_success()
406382

407383
calls = [
408-
call(
409-
"$ld:ai:generation",
410-
context,
411-
{"variationKey": "variation-key", "configKey": "config-key", "version": 3, "modelName": "fakeModel", "providerName": "fakeProvider"},
412-
1,
413-
),
414384
call(
415385
"$ld:ai:generation:success",
416386
context,
@@ -430,12 +400,6 @@ def test_tracks_error(client: LDClient):
430400
tracker.track_error()
431401

432402
calls = [
433-
call(
434-
"$ld:ai:generation",
435-
context,
436-
{"variationKey": "variation-key", "configKey": "config-key", "version": 3, "modelName": "fakeModel", "providerName": "fakeProvider"},
437-
1,
438-
),
439403
call(
440404
"$ld:ai:generation:error",
441405
context,
@@ -456,22 +420,10 @@ def test_error_overwrites_success(client: LDClient):
456420
tracker.track_error()
457421

458422
calls = [
459-
call(
460-
"$ld:ai:generation",
461-
context,
462-
{"variationKey": "variation-key", "configKey": "config-key", "version": 3, "modelName": "fakeModel", "providerName": "fakeProvider"},
463-
1,
464-
),
465423
call(
466424
"$ld:ai:generation:success",
467425
context,
468-
{"variationKey": "variation-key", "configKey": "config-key", "version": 3, "modelName": "fakeModel", "providerName": "fakeProvider"},
469-
1,
470-
),
471-
call(
472-
"$ld:ai:generation",
473-
context,
474-
{"variationKey": "variation-key", "configKey": "config-key", "version": 3, "modelName": "fakeModel", "providerName": "fakeProvider"},
426+
{"variationKey": "variation-key", "configKey": "config-key", "version": 3},
475427
1,
476428
),
477429
call(

ldai/tracker.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -184,9 +184,6 @@ def track_success(self) -> None:
184184
Track a successful AI generation.
185185
"""
186186
self._summary._success = True
187-
self._ld_client.track(
188-
"$ld:ai:generation", self._context, self.__get_track_data(), 1
189-
)
190187
self._ld_client.track(
191188
"$ld:ai:generation:success", self._context, self.__get_track_data(), 1
192189
)
@@ -196,9 +193,6 @@ def track_error(self) -> None:
196193
Track an unsuccessful AI generation attempt.
197194
"""
198195
self._summary._success = False
199-
self._ld_client.track(
200-
"$ld:ai:generation", self._context, self.__get_track_data(), 1
201-
)
202196
self._ld_client.track(
203197
"$ld:ai:generation:error", self._context, self.__get_track_data(), 1
204198
)

0 commit comments

Comments
 (0)