Skip to content

Commit 9a86f0a

Browse files
keelerm84keelerm84
committed
fix!: Rename prompt to messages
1 parent 48db88c commit 9a86f0a

File tree

2 files changed

+36
-36
lines changed

2 files changed

+36
-36
lines changed

‎ldai/client.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,11 @@ def get_attribute(self, key: str) -> Any:
7474

7575

7676
class AIConfig:
77-
def __init__(self, tracker: LDAIConfigTracker, enabled: bool, model: Optional[ModelConfig], prompt: Optional[List[LDMessage]]):
77+
def __init__(self, tracker: LDAIConfigTracker, enabled: bool, model: Optional[ModelConfig], messages: Optional[List[LDMessage]]):
7878
self.tracker = tracker
7979
self.enabled = enabled
8080
self.model = model
81-
self.prompt = prompt
81+
self.messages = messages
8282

8383

8484
class LDAIClient:
@@ -110,18 +110,18 @@ def model_config(
110110
all_variables.update(variables)
111111
all_variables['ldctx'] = context
112112

113-
prompt = None
114-
if 'prompt' in variation and isinstance(variation['prompt'], list) and all(
115-
isinstance(entry, dict) for entry in variation['prompt']
113+
messages = None
114+
if 'messages' in variation and isinstance(variation['messages'], list) and all(
115+
isinstance(entry, dict) for entry in variation['messages']
116116
):
117-
prompt = [
117+
messages = [
118118
LDMessage(
119119
role=entry['role'],
120120
content=self.__interpolate_template(
121121
entry['content'], all_variables
122122
),
123123
)
124-
for entry in variation['prompt']
124+
for entry in variation['messages']
125125
]
126126

127127
model = None
@@ -143,7 +143,7 @@ def model_config(
143143
),
144144
enabled=bool(enabled),
145145
model=model,
146-
prompt=prompt
146+
messages=messages
147147
)
148148

149149
def __interpolate_template(self, template: str, variables: Dict[str, Any]) -> str:

‎ldai/testing/test_model_config.py

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ def td() -> TestData:
1414
.variations(
1515
{
1616
'model': {'modelId': 'fakeModel', 'temperature': 0.5, 'maxTokens': 4096},
17-
'prompt': [{'role': 'system', 'content': 'Hello, {{name}}!'}],
17+
'messages': [{'role': 'system', 'content': 'Hello, {{name}}!'}],
1818
'_ldMeta': {'enabled': True, 'versionKey': 'abcd'},
1919
},
2020
"green",
@@ -23,11 +23,11 @@ def td() -> TestData:
2323
)
2424

2525
td.update(
26-
td.flag('multiple-prompt')
26+
td.flag('multiple-messages')
2727
.variations(
2828
{
2929
'model': {'modelId': 'fakeModel', 'temperature': 0.7, 'maxTokens': 8192},
30-
'prompt': [
30+
'messages': [
3131
{'role': 'system', 'content': 'Hello, {{name}}!'},
3232
{'role': 'user', 'content': 'The day is, {{day}}!'},
3333
],
@@ -43,7 +43,7 @@ def td() -> TestData:
4343
.variations(
4444
{
4545
'model': {'modelId': 'fakeModel', 'extra-attribute': 'I can be anything I set my mind/type to'},
46-
'prompt': [{'role': 'system', 'content': 'Hello, {{ldctx.name}}!'}],
46+
'messages': [{'role': 'system', 'content': 'Hello, {{ldctx.name}}!'}],
4747
'_ldMeta': {'enabled': True, 'versionKey': 'abcd'},
4848
}
4949
)
@@ -55,7 +55,7 @@ def td() -> TestData:
5555
.variations(
5656
{
5757
'model': {'modelId': 'fakeModel', 'temperature': 0.1},
58-
'prompt': [{'role': 'system', 'content': 'Hello, {{name}}!'}],
58+
'messages': [{'role': 'system', 'content': 'Hello, {{name}}!'}],
5959
'_ldMeta': {'enabled': False, 'versionKey': 'abcd'},
6060
}
6161
)
@@ -127,15 +127,15 @@ def test_model_config_interpolation(ldai_client: LDAIClient, tracker):
127127
tracker=tracker,
128128
enabled=True,
129129
model=ModelConfig('fakeModel'),
130-
prompt=[LDMessage(role='system', content='Hello, {{name}}!')],
130+
messages=[LDMessage(role='system', content='Hello, {{name}}!')],
131131
)
132132
variables = {'name': 'World'}
133133

134134
config = ldai_client.model_config('model-config', context, default_value, variables)
135135

136-
assert config.prompt is not None
137-
assert len(config.prompt) > 0
138-
assert config.prompt[0].content == 'Hello, World!'
136+
assert config.messages is not None
137+
assert len(config.messages) > 0
138+
assert config.messages[0].content == 'Hello, World!'
139139
assert config.enabled is True
140140

141141
assert config.model is not None
@@ -146,13 +146,13 @@ def test_model_config_interpolation(ldai_client: LDAIClient, tracker):
146146

147147
def test_model_config_no_variables(ldai_client: LDAIClient, tracker):
148148
context = Context.create('user-key')
149-
default_value = AIConfig(tracker=tracker, enabled=True, model=ModelConfig('fake-model'), prompt=[])
149+
default_value = AIConfig(tracker=tracker, enabled=True, model=ModelConfig('fake-model'), messages=[])
150150

151151
config = ldai_client.model_config('model-config', context, default_value, {})
152152

153-
assert config.prompt is not None
154-
assert len(config.prompt) > 0
155-
assert config.prompt[0].content == 'Hello, !'
153+
assert config.messages is not None
154+
assert len(config.messages) > 0
155+
assert config.messages[0].content == 'Hello, !'
156156
assert config.enabled is True
157157

158158
assert config.model is not None
@@ -163,16 +163,16 @@ def test_model_config_no_variables(ldai_client: LDAIClient, tracker):
163163

164164
def test_context_interpolation(ldai_client: LDAIClient, tracker):
165165
context = Context.builder('user-key').name("Sandy").build()
166-
default_value = AIConfig(tracker=tracker, enabled=True, model=ModelConfig('fake-model'), prompt=[])
166+
default_value = AIConfig(tracker=tracker, enabled=True, model=ModelConfig('fake-model'), messages=[])
167167
variables = {'name': 'World'}
168168

169169
config = ldai_client.model_config(
170170
'ctx-interpolation', context, default_value, variables
171171
)
172172

173-
assert config.prompt is not None
174-
assert len(config.prompt) > 0
175-
assert config.prompt[0].content == 'Hello, Sandy!'
173+
assert config.messages is not None
174+
assert len(config.messages) > 0
175+
assert config.messages[0].content == 'Hello, Sandy!'
176176
assert config.enabled is True
177177

178178
assert config.model is not None
@@ -184,17 +184,17 @@ def test_context_interpolation(ldai_client: LDAIClient, tracker):
184184

185185
def test_model_config_multiple(ldai_client: LDAIClient, tracker):
186186
context = Context.create('user-key')
187-
default_value = AIConfig(tracker=tracker, enabled=True, model=ModelConfig('fake-model'), prompt=[])
187+
default_value = AIConfig(tracker=tracker, enabled=True, model=ModelConfig('fake-model'), messages=[])
188188
variables = {'name': 'World', 'day': 'Monday'}
189189

190190
config = ldai_client.model_config(
191-
'multiple-prompt', context, default_value, variables
191+
'multiple-messages', context, default_value, variables
192192
)
193193

194-
assert config.prompt is not None
195-
assert len(config.prompt) > 0
196-
assert config.prompt[0].content == 'Hello, World!'
197-
assert config.prompt[1].content == 'The day is, Monday!'
194+
assert config.messages is not None
195+
assert len(config.messages) > 0
196+
assert config.messages[0].content == 'Hello, World!'
197+
assert config.messages[1].content == 'The day is, Monday!'
198198
assert config.enabled is True
199199

200200
assert config.model is not None
@@ -205,7 +205,7 @@ def test_model_config_multiple(ldai_client: LDAIClient, tracker):
205205

206206
def test_model_config_disabled(ldai_client: LDAIClient, tracker):
207207
context = Context.create('user-key')
208-
default_value = AIConfig(tracker=tracker, enabled=False, model=ModelConfig('fake-model'), prompt=[])
208+
default_value = AIConfig(tracker=tracker, enabled=False, model=ModelConfig('fake-model'), messages=[])
209209

210210
config = ldai_client.model_config('off-config', context, default_value, {})
211211

@@ -218,21 +218,21 @@ def test_model_config_disabled(ldai_client: LDAIClient, tracker):
218218

219219
def test_model_initial_config_disabled(ldai_client: LDAIClient, tracker):
220220
context = Context.create('user-key')
221-
default_value = AIConfig(tracker=tracker, enabled=False, model=ModelConfig('fake-model'), prompt=[])
221+
default_value = AIConfig(tracker=tracker, enabled=False, model=ModelConfig('fake-model'), messages=[])
222222

223223
config = ldai_client.model_config('initial-config-disabled', context, default_value, {})
224224

225225
assert config.enabled is False
226226
assert config.model is None
227-
assert config.prompt is None
227+
assert config.messages is None
228228

229229

230230
def test_model_initial_config_enabled(ldai_client: LDAIClient, tracker):
231231
context = Context.create('user-key')
232-
default_value = AIConfig(tracker=tracker, enabled=False, model=ModelConfig('fake-model'), prompt=[])
232+
default_value = AIConfig(tracker=tracker, enabled=False, model=ModelConfig('fake-model'), messages=[])
233233

234234
config = ldai_client.model_config('initial-config-enabled', context, default_value, {})
235235

236236
assert config.enabled is True
237237
assert config.model is None
238-
assert config.prompt is None
238+
assert config.messages is None

0 commit comments

Comments
 (0)