use inheritance for configs for consistency

Author: jsonbailey

ldai/models.py

@@ -139,61 +139,91 @@ def to_dict(self) -> dict:
 
 
 # ============================================================================
-# Completion Config Types
+# Base AI Config Types
 # ============================================================================
 
 @dataclass(frozen=True)
-class AICompletionConfigDefault:
+class AIConfigDefault:
     """
-    Default Completion AI Config (default mode).
+    Base AI Config interface for default implementations with optional enabled property.
     """
     enabled: Optional[bool] = None
     model: Optional[ModelConfig] = None
-    messages: Optional[List[LDMessage]] = None
     provider: Optional[ProviderConfig] = None
-    judge_configuration: Optional[JudgeConfiguration] = None
 
-    def to_dict(self) -> dict:
+    def _base_to_dict(self) -> Dict[str, Any]:
         """
-        Render the given default values as an AICompletionConfigDefault-compatible dictionary object.
+        Render the base config fields as a dictionary object.
         """
-        result = {
+        return {
             '_ldMeta': {
                 'enabled': self.enabled or False,
             },
             'model': self.model.to_dict() if self.model else None,
-            'messages': [message.to_dict() for message in self.messages] if self.messages else None,
             'provider': self.provider.to_dict() if self.provider else None,
         }
-        if self.judge_configuration is not None:
-            result['judgeConfiguration'] = self.judge_configuration.to_dict()
-        return result
 
 
 @dataclass(frozen=True)
-class AICompletionConfig:
+class AIConfig:
     """
-    Completion AI Config (default mode).
+    Base AI Config interface without mode-specific fields.
     """
     enabled: bool
     model: Optional[ModelConfig] = None
-    messages: Optional[List[LDMessage]] = None
     provider: Optional[ProviderConfig] = None
     tracker: Optional[LDAIConfigTracker] = None
-    judge_configuration: Optional[JudgeConfiguration] = None
 
-    def to_dict(self) -> dict:
+    def _base_to_dict(self) -> Dict[str, Any]:
         """
-        Render the given completion config as a dictionary object.
+        Render the base config fields as a dictionary object.
         """
-        result = {
+        return {
             '_ldMeta': {
                 'enabled': self.enabled,
             },
             'model': self.model.to_dict() if self.model else None,
-            'messages': [message.to_dict() for message in self.messages] if self.messages else None,
             'provider': self.provider.to_dict() if self.provider else None,
         }
+
+
+# ============================================================================
+# Completion Config Types
+# ============================================================================
+
+@dataclass(frozen=True)
+class AICompletionConfigDefault(AIConfigDefault):
+    """
+    Default Completion AI Config (default mode).
+    """
+    messages: Optional[List[LDMessage]] = None
+    judge_configuration: Optional[JudgeConfiguration] = None
+
+    def to_dict(self) -> dict:
+        """
+        Render the given default values as an AICompletionConfigDefault-compatible dictionary object.
+        """
+        result = self._base_to_dict()
+        result['messages'] = [message.to_dict() for message in self.messages] if self.messages else None
+        if self.judge_configuration is not None:
+            result['judgeConfiguration'] = self.judge_configuration.to_dict()
+        return result
+
+
+@dataclass(frozen=True)
+class AICompletionConfig(AIConfig):
+    """
+    Completion AI Config (default mode).
+    """
+    messages: Optional[List[LDMessage]] = None
+    judge_configuration: Optional[JudgeConfiguration] = None
+
+    def to_dict(self) -> dict:
+        """
+        Render the given completion config as a dictionary object.
+        """
+        result = self._base_to_dict()
+        result['messages'] = [message.to_dict() for message in self.messages] if self.messages else None
         if self.judge_configuration is not None:
             result['judgeConfiguration'] = self.judge_configuration.to_dict()
         return result
@@ -203,29 +233,19 @@ def to_dict(self) -> dict:
 # Agent Config Types
 # ============================================================================
 
-
 @dataclass(frozen=True)
-class AIAgentConfigDefault:
+class AIAgentConfigDefault(AIConfigDefault):
     """
     Default Agent-specific AI Config with instructions.
     """
-    enabled: Optional[bool] = None
-    model: Optional[ModelConfig] = None
-    provider: Optional[ProviderConfig] = None
     instructions: Optional[str] = None
     judge_configuration: Optional[JudgeConfiguration] = None
 
     def to_dict(self) -> Dict[str, Any]:
         """
         Render the given agent config default as a dictionary object.
         """
-        result: Dict[str, Any] = {
-            '_ldMeta': {
-                'enabled': self.enabled or False,
-            },
-            'model': self.model.to_dict() if self.model else None,
-            'provider': self.provider.to_dict() if self.provider else None,
-        }
+        result = self._base_to_dict()
         if self.instructions is not None:
             result['instructions'] = self.instructions
         if self.judge_configuration is not None:
@@ -234,28 +254,18 @@ def to_dict(self) -> Dict[str, Any]:
 
 
 @dataclass(frozen=True)
-class AIAgentConfig:
+class AIAgentConfig(AIConfig):
     """
     Agent-specific AI Config with instructions.
     """
-    enabled: bool
-    model: Optional[ModelConfig] = None
-    provider: Optional[ProviderConfig] = None
     instructions: Optional[str] = None
-    tracker: Optional[LDAIConfigTracker] = None
     judge_configuration: Optional[JudgeConfiguration] = None
 
     def to_dict(self) -> Dict[str, Any]:
         """
         Render the given agent config as a dictionary object.
         """
-        result: Dict[str, Any] = {
-            '_ldMeta': {
-                'enabled': self.enabled,
-            },
-            'model': self.model.to_dict() if self.model else None,
-            'provider': self.provider.to_dict() if self.provider else None,
-        }
+        result = self._base_to_dict()
         if self.instructions is not None:
             result['instructions'] = self.instructions
         if self.judge_configuration is not None:
@@ -268,58 +278,39 @@ def to_dict(self) -> Dict[str, Any]:
 # ============================================================================
 
 @dataclass(frozen=True)
-class AIJudgeConfigDefault:
+class AIJudgeConfigDefault(AIConfigDefault):
     """
     Default Judge-specific AI Config with required evaluation metric key.
     """
-    enabled: Optional[bool] = None
-    model: Optional[ModelConfig] = None
     messages: Optional[List[LDMessage]] = None
-    provider: Optional[ProviderConfig] = None
     evaluation_metric_keys: Optional[List[str]] = None
 
     def to_dict(self) -> dict:
         """
         Render the given judge config default as a dictionary object.
         """
-        result = {
-            '_ldMeta': {
-                'enabled': self.enabled or False,
-            },
-            'model': self.model.to_dict() if self.model else None,
-            'messages': [message.to_dict() for message in self.messages] if self.messages else None,
-            'provider': self.provider.to_dict() if self.provider else None,
-        }
+        result = self._base_to_dict()
+        result['messages'] = [message.to_dict() for message in self.messages] if self.messages else None
         if self.evaluation_metric_keys is not None:
             result['evaluationMetricKeys'] = self.evaluation_metric_keys
         return result
 
 
 @dataclass(frozen=True)
-class AIJudgeConfig:
+class AIJudgeConfig(AIConfig):
     """
     Judge-specific AI Config with required evaluation metric key.
     """
-    enabled: bool
     evaluation_metric_keys: List[str]
-    model: Optional[ModelConfig] = None
     messages: Optional[List[LDMessage]] = None
-    provider: Optional[ProviderConfig] = None
-    tracker: Optional[LDAIConfigTracker] = None
 
     def to_dict(self) -> dict:
         """
         Render the given judge config as a dictionary object.
         """
-        result = {
-            '_ldMeta': {
-                'enabled': self.enabled,
-            },
-            'evaluationMetricKeys': self.evaluation_metric_keys,
-            'model': self.model.to_dict() if self.model else None,
-            'messages': [message.to_dict() for message in self.messages] if self.messages else None,
-            'provider': self.provider.to_dict() if self.provider else None,
-        }
+        result = self._base_to_dict()
+        result['evaluationMetricKeys'] = self.evaluation_metric_keys
+        result['messages'] = [message.to_dict() for message in self.messages] if self.messages else None
         return result