From 6bd35eed912f541c23a66e8139b81e7b2111fd3d Mon Sep 17 00:00:00 2001 From: jsonbailey Date: Tue, 29 Jul 2025 14:11:12 +0000 Subject: [PATCH 1/2] fix: Remove deprecated track generation event --- ldai/testing/test_tracker.py | 8 -------- ldai/tracker.py | 6 ------ 2 files changed, 14 deletions(-) diff --git a/ldai/testing/test_tracker.py b/ldai/testing/test_tracker.py index 3c584b7..40a8d28 100644 --- a/ldai/testing/test_tracker.py +++ b/ldai/testing/test_tracker.py @@ -149,7 +149,6 @@ def test_tracks_bedrock_metrics(client: LDClient): tracker.track_bedrock_converse_metrics(bedrock_result) calls = [ - call('$ld:ai:generation', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1), call('$ld:ai:generation:success', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1), call('$ld:ai:duration:total', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 50), call('$ld:ai:tokens:total', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 330), @@ -182,7 +181,6 @@ def test_tracks_bedrock_metrics_with_error(client: LDClient): tracker.track_bedrock_converse_metrics(bedrock_result) calls = [ - call('$ld:ai:generation', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1), call('$ld:ai:generation:error', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1), call('$ld:ai:duration:total', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 50), call('$ld:ai:tokens:total', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 330), @@ -216,7 +214,6 @@ def to_dict(self): tracker.track_openai_metrics(lambda: Result()) calls = [ - call('$ld:ai:generation', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1), call('$ld:ai:generation:success', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1), call('$ld:ai:tokens:total', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 330), call('$ld:ai:tokens:input', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 220), @@ -242,7 +239,6 @@ def raise_exception(): pass calls = [ - call('$ld:ai:generation', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1), call('$ld:ai:generation:error', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1), ] @@ -279,7 +275,6 @@ def test_tracks_success(client: LDClient): tracker.track_success() calls = [ - call('$ld:ai:generation', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1), call('$ld:ai:generation:success', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1), ] @@ -294,7 +289,6 @@ def test_tracks_error(client: LDClient): tracker.track_error() calls = [ - call('$ld:ai:generation', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1), call('$ld:ai:generation:error', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1), ] @@ -310,9 +304,7 @@ def test_error_overwrites_success(client: LDClient): tracker.track_error() calls = [ - call('$ld:ai:generation', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1), call('$ld:ai:generation:success', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1), - call('$ld:ai:generation', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1), call('$ld:ai:generation:error', context, {'variationKey': 'variation-key', 'configKey': 'config-key', 'version': 3}, 1), ] diff --git a/ldai/tracker.py b/ldai/tracker.py index 33d53ed..9e0f941 100644 --- a/ldai/tracker.py +++ b/ldai/tracker.py @@ -168,9 +168,6 @@ def track_success(self) -> None: Track a successful AI generation. """ self._summary._success = True - self._ld_client.track( - '$ld:ai:generation', self._context, self.__get_track_data(), 1 - ) self._ld_client.track( '$ld:ai:generation:success', self._context, self.__get_track_data(), 1 ) @@ -180,9 +177,6 @@ def track_error(self) -> None: Track an unsuccessful AI generation attempt. """ self._summary._success = False - self._ld_client.track( - '$ld:ai:generation', self._context, self.__get_track_data(), 1 - ) self._ld_client.track( '$ld:ai:generation:error', self._context, self.__get_track_data(), 1 ) From 90dec0b0d0f12991283ac143f25c520729baca32 Mon Sep 17 00:00:00 2001 From: jsonbailey Date: Tue, 29 Jul 2025 15:59:07 +0000 Subject: [PATCH 2/2] fix failing test --- ldai/testing/test_tracker.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/ldai/testing/test_tracker.py b/ldai/testing/test_tracker.py index 1f6915b..30a20bd 100644 --- a/ldai/testing/test_tracker.py +++ b/ldai/testing/test_tracker.py @@ -422,12 +422,6 @@ def test_error_overwrites_success(client: LDClient): {"variationKey": "variation-key", "configKey": "config-key", "version": 3}, 1, ), - call( - "$ld:ai:generation", - context, - {"variationKey": "variation-key", "configKey": "config-key", "version": 3}, - 1, - ), call( "$ld:ai:generation:error", context,