Don't call variation when initializing

Author: XieX

src/initLDClient.test.ts

@@ -58,18 +58,6 @@ describe('initLDClient', () => {
     expect(mockLDClient.variation).toHaveBeenCalledTimes(0);
   });
 
-  test('initialise should call variation if flags are specified', async () => {
-    const customUser = { key: '[email protected]' };
-    const targetFlags = { 'lonely-flag': false, 'lonelier-flag': false };
-
-    const flagsClient = await initLDClient(clientSideID, customUser, options, targetFlags);
-
-    expect(mockLDClient.variation).toHaveBeenCalledTimes(2);
-    expect(mockLDClient.variation).toHaveBeenNthCalledWith(1, 'lonely-flag', false);
-    expect(mockLDClient.variation).toHaveBeenNthCalledWith(2, 'lonelier-flag', false);
-    expect(flagsClient).toEqual({ flags: { 'lonely-flag': true, 'lonelier-flag': true }, ldClient: mockLDClient });
-  });
-
   test('may explicity set sendEventsOnlyForVariation to false', async () => {
     const anonUser: LDUser = { anonymous: true };
     await initLDClient(clientSideID, undefined, { ...options, sendEventsOnlyForVariation: false });

src/utils.test.ts

@@ -85,20 +85,17 @@ describe('Utils', () => {
       };
     });
 
-    test('should return variations for the target flags', () => {
+    test('should return only the target flags', () => {
       const targetFlags = { 'target-one': true, 'target-two': true, 'target-three': false };
       const flagSet = fetchFlags(mockLDClient as LDClient, targetFlags);
 
-      expect(mockLDClient.allFlags).toBeCalledTimes(0);
-      expect(mockLDClient.variation).toBeCalledTimes(3);
       expect(flagSet).toEqual({ 'target-one': true, 'target-three': false, 'target-two': true });
     });
 
     test('should return all flags when target flags is not defined', () => {
       const flagSet = fetchFlags(mockLDClient as LDClient, undefined);
 
       expect(mockLDClient.allFlags).toBeCalledTimes(1);
-      expect(mockLDClient.variation).toBeCalledTimes(0);
       expect(flagSet).toEqual({ 'example-flag': true, 'test-example': false });
     });
   });

src/utils.ts

@@ -54,17 +54,16 @@ export const getFlattenedFlagsFromChangeset = (
  * @returns an `LDFlagSet` with the current flag values from LaunchDarkly filtered by `targetFlags`.
  */
 export const fetchFlags = (ldClient: LDClient, targetFlags?: LDFlagSet) => {
-  let rawFlags: LDFlagSet = {};
-
-  if (targetFlags) {
-    for (const flag in targetFlags) {
-      rawFlags[flag] = ldClient.variation(flag, targetFlags[flag]);
-    }
-  } else {
-    rawFlags = ldClient.allFlags();
+  const allFlags = ldClient.allFlags();
+  if (!targetFlags) {
+    return allFlags;
   }
 
-  return rawFlags;
+  return Object.keys(targetFlags).reduce<LDFlagSet>((acc, key) => {
+    acc[key] = Object.prototype.hasOwnProperty.call(allFlags, key) ? allFlags[key] : targetFlags[key];
+
+    return acc;
+  }, {});
 };
 
 /**