Merge pull request #58 from launchdarkly/christie/sc-161955/don-t-send-events-for-all-flags-on-load-by

Don't send events for all flags on load by

Author: XieX

src/initLDClient.test.ts

@@ -17,7 +17,11 @@ const ldClientInitialize = initialize as jest.Mock;
 const clientSideID = 'deadbeef';
 const defaultUser: LDUser = { key: 'abcdef' };
 const options: LDOptions = { bootstrap: 'localStorage' };
-const extraOptionsAddedBySdk: LDOptions = { wrapperName: 'react-client-sdk', wrapperVersion: 'mock.version' };
+const extraOptionsAddedBySdk: LDOptions = {
+  wrapperName: 'react-client-sdk',
+  wrapperVersion: 'mock.version',
+  sendEventsOnlyForVariation: true,
+};
 const expectedOptions: LDOptions = { ...options, ...extraOptionsAddedBySdk };
 const flags = { 'test-flag': false, 'another-test-flag': true };
 
@@ -89,4 +93,16 @@ describe('initLDClient', () => {
     expect(mockLDClient.variation).toHaveBeenNthCalledWith(2, 'lonelier-flag', false);
     expect(flagsClient).toEqual({ flags: { lonelyFlag: true, lonelierFlag: true }, ldClient: mockLDClient });
   });
+
+  test('may explicity set sendEventsOnlyForVariation to false', async () => {
+    const anonUser: LDUser = { anonymous: true };
+    await initLDClient(clientSideID, undefined, undefined, { ...options, sendEventsOnlyForVariation: false });
+
+    expect(ldClientInitialize.mock.calls[0]).toEqual([
+      clientSideID,
+      anonUser,
+      { ...expectedOptions, sendEventsOnlyForVariation: false },
+    ]);
+    expect(mockLDClient.variation).toHaveBeenCalledTimes(0);
+  });
 });

src/initLDClient.ts

@@ -3,6 +3,12 @@ import { AllFlagsLDClient, defaultReactOptions, LDReactOptions } from './types';
 import { fetchFlags } from './utils';
 import * as packageInfo from '../package.json';
 
+const wrapperOptions: LDOptions = {
+  wrapperName: 'react-client-sdk',
+  wrapperVersion: packageInfo.version,
+  sendEventsOnlyForVariation: true,
+};
+
 /**
  * Internal function to initialize the `LDClient`.
  *
@@ -22,8 +28,7 @@ const initLDClient = async (
   options?: LDOptions,
   targetFlags?: LDFlagSet,
 ): Promise<AllFlagsLDClient> => {
-  const allOptions = { wrapperName: 'react-client-sdk', wrapperVersion: packageInfo.version, ...options };
-  const ldClient = ldClientInitialize(clientSideID, user, allOptions);
+  const ldClient = ldClientInitialize(clientSideID, user, { ...wrapperOptions, ...options });
 
   return new Promise<AllFlagsLDClient>((resolve) => {
     ldClient.on('ready', () => {