Skip to content

Commit 0250999

Browse files
committed
We should expect symbols, simplify the code and remove error with boolean value parsing
1 parent ff982dd commit 0250999

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

lib/ldclient-rb/impl/data_system/protocolv2.rb

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,9 @@ def to_h
6666
# @raise [ArgumentError] if required fields are missing
6767
#
6868
def self.from_h(data)
69-
version = data['version'] || data[:version]
70-
kind = data['kind'] || data[:kind]
71-
key = data['key'] || data[:key]
69+
version = data[:version]
70+
kind = data[:kind]
71+
key = data[:key]
7272

7373
raise ArgumentError, "Missing required fields in DeleteObject" if version.nil? || kind.nil? || key.nil?
7474

@@ -139,10 +139,10 @@ def to_h
139139
# @raise [ArgumentError] if required fields are missing
140140
#
141141
def self.from_h(data)
142-
version = data['version'] || data[:version]
143-
kind = data['kind'] || data[:kind]
144-
key = data['key'] || data[:key]
145-
object_data = data['object'] || data[:object]
142+
version = data[:version]
143+
kind = data[:kind]
144+
key = data[:key]
145+
object_data = data[:object]
146146

147147
raise ArgumentError, "Missing required fields in PutObject" if version.nil? || kind.nil? || key.nil? || object_data.nil?
148148

@@ -198,9 +198,9 @@ def to_h
198198
# @raise [ArgumentError] if required fields are missing
199199
#
200200
def self.from_h(data)
201-
reason = data['reason'] || data[:reason]
202-
silent = data['silent'] || data[:silent]
203-
catastrophe = data['catastrophe'] || data[:catastrophe]
201+
reason = data[:reason]
202+
silent = data[:silent]
203+
catastrophe = data[:catastrophe]
204204

205205
raise ArgumentError, "Missing required fields in Goodbye" if reason.nil? || silent.nil? || catastrophe.nil?
206206

@@ -250,8 +250,8 @@ def to_h
250250
# @raise [ArgumentError] if required fields are missing
251251
#
252252
def self.from_h(data)
253-
payload_id = data['payloadId'] || data[:payloadId] || data[:payload_id]
254-
reason = data['reason'] || data[:reason]
253+
payload_id = data[:payloadId]
254+
reason = data[:reason]
255255

256256
raise ArgumentError, "Missing required fields in Error" if payload_id.nil? || reason.nil?
257257

0 commit comments

Comments
 (0)