set proper availability for daemon mode

Author: jsonbailey

lib/ldclient-rb/impl/datasystem/fdv1.rb

@@ -163,17 +163,13 @@ def flag_tracker
         # @return [Symbol] One of DataAvailability constants
         #
         def data_availability
-          if @config.offline?
-            return DataAvailability::DEFAULTS
-          end
+          return DataAvailability::DEFAULTS if @config.offline?
 
-          if @update_processor && @update_processor.initialized?
-            return DataAvailability::REFRESHED
+          unless @config.use_ldd?
+            return DataAvailability::REFRESHED if @update_processor && @update_processor.initialized?
           end
 
-          if @store_wrapper.initialized?
-            return DataAvailability::CACHED
-          end
+          return DataAvailability::CACHED if @store_wrapper.initialized?
 
           DataAvailability::DEFAULTS
         end
@@ -184,10 +180,9 @@ def data_availability
         # @return [Symbol] One of DataAvailability constants
         #
         def target_availability
-          if @config.offline?
-            return DataAvailability::DEFAULTS
-          end
-          # In LDD mode or normal connected modes, the ideal is to be refreshed
+          return DataAvailability::DEFAULTS if @config.offline?
+          return DataAvailability::CACHED if @config.use_ldd?
+
           DataAvailability::REFRESHED
         end
 

spec/impl/datasystem/fdv1_spec.rb

@@ -212,6 +212,21 @@ module DataSystem
               expect(subject.data_availability).to eq(DataAvailability::DEFAULTS)
             end
           end
+
+          context "in LDD mode" do
+            let(:config) { LaunchDarkly::Config.new(use_ldd: true) }
+
+            it "returns DEFAULTS when store is empty" do
+              subject.start
+              expect(subject.data_availability).to eq(DataAvailability::DEFAULTS)
+            end
+
+            it "returns CACHED when store is initialized" do
+              subject.start
+              subject.store.init({})
+              expect(subject.data_availability).to eq(DataAvailability::CACHED)
+            end
+          end
         end
 
         describe "#target_availability" do
@@ -232,8 +247,8 @@ module DataSystem
           context "with LDD mode" do
             let(:config) { LaunchDarkly::Config.new(use_ldd: true) }
 
-            it "returns REFRESHED" do
-              expect(subject.target_availability).to eq(DataAvailability::REFRESHED)
+            it "returns CACHED" do
+              expect(subject.target_availability).to eq(DataAvailability::CACHED)
             end
           end
         end