Skip to content

Commit 2eca9c9

Browse files
committed
always return cached for ldd mode
1 parent 8784a7e commit 2eca9c9

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

lib/ldclient-rb/impl/datasystem/fdv1.rb

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,10 +151,13 @@ def flag_change_broadcaster
151151
def data_availability
152152
return DataAvailability::DEFAULTS if @config.offline?
153153

154-
unless @config.use_ldd?
155-
return DataAvailability::REFRESHED if @update_processor && @update_processor.initialized?
156-
end
154+
# In LDD mode, always return CACHED for backwards compatibility.
155+
# Even though the store might be empty (technically DEFAULTS), we maintain
156+
# the existing behavior where LDD mode is assumed to have data available
157+
# from the external daemon, regardless of the store's initialization state.
158+
return DataAvailability::CACHED if @config.use_ldd?
157159

160+
return DataAvailability::REFRESHED if @update_processor && @update_processor.initialized?
158161
return DataAvailability::CACHED if @store_wrapper.initialized?
159162

160163
DataAvailability::DEFAULTS

spec/impl/datasystem/fdv1_spec.rb

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -208,13 +208,12 @@ module DataSystem
208208
context "in LDD mode" do
209209
let(:config) { LaunchDarkly::Config.new(use_ldd: true) }
210210

211-
it "returns DEFAULTS when store is empty" do
212-
subject.start
213-
expect(subject.data_availability).to eq(DataAvailability::DEFAULTS)
214-
end
215-
216-
it "returns CACHED when store is initialized" do
211+
it "always returns CACHED for backwards compatibility" do
217212
subject.start
213+
# Returns CACHED even when store is empty
214+
expect(subject.data_availability).to eq(DataAvailability::CACHED)
215+
216+
# Still returns CACHED when store is initialized
218217
subject.store.init({})
219218
expect(subject.data_availability).to eq(DataAvailability::CACHED)
220219
end

0 commit comments

Comments
 (0)