return refreshed for backwards compatibility if ldd mode

Author: jsonbailey

lib/ldclient-rb/impl/data_system/fdv1.rb

@@ -116,13 +116,6 @@ def flag_change_broadcaster
         #
         def data_availability
           return DataAvailability::DEFAULTS if @config.offline?
-
-          # In LDD mode, always return CACHED for backwards compatibility.
-          # Even though the store might be empty (technically DEFAULTS), we maintain
-          # the existing behavior where LDD mode is assumed to have data available
-          # from the external daemon, regardless of the store's initialization state.
-          return DataAvailability::CACHED if @config.use_ldd?
-
           return DataAvailability::REFRESHED if @update_processor && @update_processor.initialized?
           return DataAvailability::CACHED if @store_wrapper.initialized?
 
@@ -132,7 +125,6 @@ def data_availability
         # (see DataSystem#target_availability)
         def target_availability
           return DataAvailability::DEFAULTS if @config.offline?
-          return DataAvailability::CACHED if @config.use_ldd?
 
           DataAvailability::REFRESHED
         end

spec/impl/data_system/fdv1_spec.rb

@@ -208,14 +208,14 @@ module DataSystem
           context "in LDD mode" do
             let(:config) { LaunchDarkly::Config.new(use_ldd: true) }
 
-            it "always returns CACHED for backwards compatibility" do
+            it "always returns REFRESHED for backwards compatibility" do
               subject.start
-              # Returns CACHED even when store is empty
-              expect(subject.data_availability).to eq(DataAvailability::CACHED)
+              # Returns REFRESHED even when store is empty
+              expect(subject.data_availability).to eq(DataAvailability::REFRESHED)
 
-              # Still returns CACHED when store is initialized
+              # Still returns REFRESHED when store is initialized
               subject.store.init({})
-              expect(subject.data_availability).to eq(DataAvailability::CACHED)
+              expect(subject.data_availability).to eq(DataAvailability::REFRESHED)
             end
           end
         end
@@ -238,8 +238,8 @@ module DataSystem
           context "with LDD mode" do
             let(:config) { LaunchDarkly::Config.new(use_ldd: true) }
 
-            it "returns CACHED" do
-              expect(subject.target_availability).to eq(DataAvailability::CACHED)
+            it "returns REFRESHED" do
+              expect(subject.target_availability).to eq(DataAvailability::REFRESHED)
             end
           end
         end