Skip to content

Commit 9ed3bc7

Browse files
committed
address warnings in rubocop and bump bundler version to resolve build errors
1 parent 90e973f commit 9ed3bc7

File tree

4 files changed

+16
-16
lines changed

4 files changed

+16
-16
lines changed

.rubocop.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
require:
1+
plugins:
22
- rubocop-performance
33

44
AllCops:
@@ -289,7 +289,7 @@ Style/PerlBackrefs:
289289
StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-perl-regexp-last-matchers'
290290
Enabled: false
291291

292-
Naming/PredicateName:
292+
Naming/PredicatePrefix:
293293
Description: 'Check the names of predicate methods.'
294294
StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#bool-methods-qmark'
295295
ForbiddenPrefixes:

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ LaunchDarkly overview
1616
Supported Ruby versions
1717
-----------------------
1818

19-
This version of the LaunchDarkly SDK has a minimum Ruby version of 2.5.0, or 9.2.0 for JRuby.
19+
This version of the LaunchDarkly SDK has a minimum Ruby version of 3.0.0, or 9.3.0 for JRuby.
2020

2121
Getting started
2222
-----------

launchdarkly-server-sdk.gemspec

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,29 +21,29 @@ Gem::Specification.new do |spec|
2121
spec.required_ruby_version = ">= 3.0.0"
2222

2323
spec.add_development_dependency "aws-sdk-dynamodb", "~> 1.57"
24-
spec.add_development_dependency "rexml", "~> 3.3", ">= 3.3.7"
25-
spec.add_development_dependency "bundler", "2.2.33"
26-
spec.add_development_dependency "simplecov", "~> 0.21"
27-
spec.add_development_dependency "rspec", "~> 3.10"
24+
spec.add_development_dependency "bundler", "~> 2.5.0"
25+
spec.add_development_dependency "connection_pool", "~> 2.3"
2826
spec.add_development_dependency "diplomat", "~> 2.6"
27+
spec.add_development_dependency "listen", "~> 3.3" # see file_data_source.rb
2928
spec.add_development_dependency "redis", "~> 5.0"
30-
spec.add_development_dependency "connection_pool", "~> 2.3"
29+
spec.add_development_dependency "rexml", "~> 3.3", ">= 3.3.7"
30+
spec.add_development_dependency "rspec", "~> 3.10"
3131
spec.add_development_dependency "rspec_junit_formatter", "~> 0.4"
32-
spec.add_development_dependency "timecop", "~> 0.9"
33-
spec.add_development_dependency "listen", "~> 3.3" # see file_data_source.rb
34-
spec.add_development_dependency "webrick", "~> 1.7"
3532
spec.add_development_dependency "rubocop", "~> 1.37"
3633
spec.add_development_dependency "rubocop-performance", "~> 1.15"
34+
spec.add_development_dependency "simplecov", "~> 0.21"
35+
spec.add_development_dependency "timecop", "~> 0.9"
36+
spec.add_development_dependency "webrick", "~> 1.7"
3737

38-
# spec.add_runtime_dependency "benchmark", "~> 0.4"
39-
spec.add_runtime_dependency "semantic", "~> 1.6"
38+
spec.add_runtime_dependency "benchmark", "~> 0.4"
4039
spec.add_runtime_dependency "concurrent-ruby", "~> 1.1"
4140
spec.add_runtime_dependency "ld-eventsource", "2.2.3"
4241
spec.add_runtime_dependency "observer", "~> 0.1.2"
42+
spec.add_runtime_dependency "semantic", "~> 1.6"
4343
spec.add_runtime_dependency "zlib", "~> 3.1" unless RUBY_PLATFORM == "java"
4444
# Please keep ld-eventsource dependency as an exact version so that bugfixes to
4545
# that LD library are always associated with a new SDK version.
4646

47-
spec.add_runtime_dependency "json", "~> 2.3"
4847
spec.add_runtime_dependency "http", ">= 4.4.0", "< 6.0.0"
48+
spec.add_runtime_dependency "json", "~> 2.3"
4949
end

spec/impl/repeating_task_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def null_logger
3838
3.times do
3939
time = queue.pop
4040
unless last.nil?
41-
expect(time.to_f - last.to_f).to be >=(0.05)
41+
expect(time.to_f - last.to_f).to be >= 0.05
4242
end
4343
last = time
4444
end
@@ -50,7 +50,7 @@ def null_logger
5050
2.times do
5151
begin
5252
time = queue.pop(true)
53-
expect(time.to_f).to be <=(stopped_time.to_f)
53+
expect(time.to_f).to be <= stopped_time.to_f
5454
rescue ThreadError
5555
no_more_items = true
5656
break

0 commit comments

Comments
 (0)