Specify names for each repeating task

Author: keelerm84

lib/ldclient-rb/impl/big_segments.rb

@@ -24,7 +24,7 @@ def initialize(big_segments_config, logger)
 
         unless @store.nil?
           @cache = ExpiringCache.new(big_segments_config.context_cache_size, big_segments_config.context_cache_time)
-          @poll_worker = RepeatingTask.new(big_segments_config.status_poll_interval, 0, -> { poll_store_and_update_status }, logger)
+          @poll_worker = RepeatingTask.new(big_segments_config.status_poll_interval, 0, -> { poll_store_and_update_status }, logger, 'LD/BigSegments#status')
           @poll_worker.start
         end
       end

lib/ldclient-rb/impl/repeating_task.rb

@@ -5,13 +5,16 @@
 module LaunchDarkly
   module Impl
     class RepeatingTask
-      def initialize(interval, start_delay, task, logger)
+      attr_reader :name
+
+      def initialize(interval, start_delay, task, logger, name)
         @interval = interval
         @start_delay = start_delay
         @task = task
         @logger = logger
         @stopped = Concurrent::AtomicBoolean.new(false)
         @worker = nil
+        @name = name
       end
 
       def start
@@ -30,9 +33,9 @@ def start
               sleep(delta)
             end
           end
-        end.tap do |worker|
-          worker.name = "LD/Impl/RepeatingTask"
         end
+
+        @worker.name = @name
       end
 
       def stop

lib/ldclient-rb/impl/store_client_wrapper.rb

@@ -99,7 +99,7 @@ def monitoring_enabled?
 
         @logger.warn("Detected persistent store unavailability; updates will be cached until it recovers.")
 
-        task = Impl::RepeatingTask.new(0.5, 0, -> { self.check_availability }, @logger)
+        task = Impl::RepeatingTask.new(0.5, 0, -> { self.check_availability }, @logger, 'LD/StoreWrapper#check_availability')
 
         @mutex.synchronize do
           @poller = task

lib/ldclient-rb/polling.rb

@@ -13,7 +13,7 @@ def initialize(config, requestor)
       @initialized = Concurrent::AtomicBoolean.new(false)
       @started = Concurrent::AtomicBoolean.new(false)
       @ready = Concurrent::Event.new
-      @task = Impl::RepeatingTask.new(@config.poll_interval, 0, -> { self.poll }, @config.logger)
+      @task = Impl::RepeatingTask.new(@config.poll_interval, 0, -> { self.poll }, @config.logger, 'LD/PollingDataSource')
     end
 
     def initialized?

spec/impl/repeating_task_spec.rb

@@ -11,9 +11,17 @@ def null_logger
         double.as_null_object
       end
 
+      it "can name the task" do
+        signal = Concurrent::Event.new
+        task = RepeatingTask.new(0.01, 0, -> { signal.set }, null_logger, "Junie B.")
+
+        expect(task.name).to eq("Junie B.")
+        task.stop
+      end
+
       it "does not start when created" do
         signal = Concurrent::Event.new
-        task = RepeatingTask.new(0.01, 0, -> { signal.set }, null_logger)
+        task = RepeatingTask.new(0.01, 0, -> { signal.set }, null_logger, "test")
         begin
           expect(signal.wait(0.1)).to be false
         ensure
@@ -23,7 +31,7 @@ def null_logger
 
       it "executes until stopped" do
         queue = Queue.new
-        task = RepeatingTask.new(0.1, 0, -> { queue << Time.now }, null_logger)
+        task = RepeatingTask.new(0.1, 0, -> { queue << Time.now }, null_logger, "test")
         begin
           last = nil
           task.start
@@ -62,7 +70,7 @@ def null_logger
               stopped.set
             end
           },
-          null_logger)
+          null_logger, "test")
         begin
           task.start
           expect(stopped.wait(0.1)).to be true