Merge pull request #180 from mmurphy-notarize/mmurphy-notarize/debug-log-patch

Debug logging patch for undefined local variable 'res' in requestor

Author: eli-darkly

lib/ldclient-rb/requestor.rb

@@ -60,9 +60,9 @@ def make_request(path)
         headers: headers
       })
       status = response.status.code
-      @config.logger.debug { "[LDClient] Got response from uri: #{uri}\n\tstatus code: #{status}\n\theaders: #{response.headers}\n\tbody: #{res.to_s}" }
       # must fully read body for persistent connections
       body = response.to_s
+      @config.logger.debug { "[LDClient] Got response from uri: #{uri}\n\tstatus code: #{status}\n\theaders: #{response.headers.to_h}\n\tbody: #{body}" }
       if status == 304 && !cached.nil?
         body = cached.body
       else

spec/requestor_spec.rb

@@ -40,6 +40,19 @@ def with_requestor(base_uri, opts = {})
       end
     end
 
+    it "logs debug output" do
+      logger = ::Logger.new($stdout)
+      logger.level = ::Logger::DEBUG
+      with_server do |server|
+        with_requestor(server.base_uri.to_s, { logger: logger }) do |requestor|
+          server.setup_ok_response("/", { flags: { x: { key: "y" } } }.to_json)
+          expect do
+            requestor.request_all_data()
+          end.to output(/\[LDClient\] Got response from uri\:/).to_stdout_from_any_process
+        end
+      end
+    end
+
     it "sends etag from previous response" do
       etag = "xyz"
       with_server do |server|