address feedbacks

Author: abelonogov-ld

Sources/LaunchDarklyObservability/Plugin/PluginError.swift

@@ -2,11 +2,14 @@ import Foundation
 
 public enum PluginError: LocalizedError {
     case observabilityInstanceAlreadyExist
+    case sessionReplayInstanceAlreadyExist
 
     public var errorDescription: String? {
         switch self {
         case .observabilityInstanceAlreadyExist:
             return "Observability plugin is already initialized, only a single instance can be initialized at runtime."
+        case .sessionReplayInstanceAlreadyExist:
+            return "Session Replay plugin is already initialized, only a single instance can be initialized at runtime."
         }
     }
 }

Sources/LaunchDarklySessionReplay/API/LDReplay.swift

@@ -1,11 +1,15 @@
 import Foundation
 import LaunchDarkly
 
-public final class LDReplay: AnyObject {
+public final class LDReplay {
     public static var shared = LDReplay()
 
     var client: SessionReplayServicing?
-        
+    
+    private init() {
+        // privacy for singleton
+    }
+    
     public func start() {
         Task { @MainActor in
             client?.start()

Sources/LaunchDarklySessionReplay/SessionReplay.swift

@@ -21,16 +21,20 @@ public final class SessionReplay: Plugin {
             os_log("%{public}@", log: options.log, type: .error, "Session Replay Service could not find Observability Service")
             return
         }
-                
+        
         observabilityContext = context
-
+        
         do {
+            guard LDReplay.shared.client == nil else {
+                throw PluginError.sessionReplayInstanceAlreadyExist
+            }
+           
             let sessionReplayService = try SessionReplayService(observabilityContext: context,
-                                                            sessonReplayOptions: options,
-                                                            metadata: metadata)
+                                                                sessonReplayOptions: options,
+                                                                metadata: metadata)
             LDReplay.shared.client = sessionReplayService
             self.sessionReplayService = sessionReplayService
-
+            
             if options.isEnabled {
                 start()
             }

Sources/LaunchDarklySessionReplay/SessionReplayService.swift

@@ -8,9 +8,8 @@ import Common
 
 protocol SessionReplayServicing {
     @MainActor
-    func start(
-        
-    )
+    func start()
+    
     @MainActor
     func stop()
 }