Restructure into pg17-full and pg17 packages #109
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created pg17-full directory with complete functionality including scan, deparse, and proto.js - Created pg17 directory as minimal package without scan/deparse functionality - Removed scan/deparse functions, interfaces, and proto.js imports from pg17 - Updated pg17 Makefile to exclude _wasm_scan and _wasm_deparse_protobuf exports - Created base Makefile to build both packages - Updated pg17 README.md to remove scan/deparse documentation - Copied README.md from pg17-full to base directory Co-Authored-By: Dan Lynch <[email protected]>
- Created pg17-full directory with complete functionality including scan, deparse, and proto.js - Created pg17 directory as minimal package without scan/deparse functionality - Removed all scan/deparse functions, interfaces, and proto.js imports from pg17 - Updated pg17 Makefile to exclude _wasm_scan and _wasm_deparse_protobuf exports - Created base Makefile to build both packages with yarn commands - Updated pg17 README.md to remove all scan/deparse documentation and interfaces - Copied README.md from pg17-full to base directory - Preserved all package.json files unchanged as requested Co-Authored-By: Dan Lynch <[email protected]>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…gement - Restore original Makefile to root for CI compatibility - Add Makefile.packages for building both pg17-full and pg17 packages - Update README to document dual package structure and build process - Fixes 'Build WASM 🔧' CI failure caused by yarn not found in emscripten container Co-Authored-By: Dan Lynch <[email protected]>
…parse from pg17 - Move all root files to pg17-full package (complete functionality) - Copy pg17-full to pg17 and remove scan/deparse functionality - Remove proto.js, SCAN.md, and scan/deparse tests from pg17 - Update TypeScript definitions and JavaScript exports in pg17 - Add Makefiles to both packages for proper building - Create base Makefile.packages for unified package management - Both packages now build successfully with WASM compilation - pg17 package is significantly smaller without scan/deparse features Co-Authored-By: Dan Lynch <[email protected]>
…deparse removal - Fix git submodule issue by properly adding pg17-full and pg17 as directories - pg17-full: Complete package with ALL original functionality (42 files) - pg17: Minimal package without scan/deparse (37 files, missing SCAN.md, proto.js, scan/deparse tests) - Removed scan/deparse functions from pg17 WASM exports and C implementation - Updated TypeScript definitions and JavaScript exports in pg17 - Both packages build successfully with proper WASM compilation - Root directory now clean except for package management files Co-Authored-By: Dan Lynch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure libpg-query-node into pg17-full and pg17 packages
This PR restructures the repository into two distinct packages as requested:
Changes Made
📁 pg17-full - Complete Package
scan,deparse, andproto.js📁 pg17 - Minimal Package
proto.js(5.4MB file) and all scan/deparse related code_wasm_scanand_wasm_deparse_protobuffrom WASM exports🔧 Base Makefile
make install,make build,make clean,make testmake pg17-fullandmake pg17📚 Documentation
Files Modified
pg17 package (scan/deparse removal):
src/index.ts- Removed scan/deparse functions and interfaceswasm/index.js- Removed scan/deparse exports and proto.js importwasm/index.d.ts- Removed scan/deparse type definitionswasm/index.cjs- Removed scan/deparse CommonJS exportssrc/libpg-query.d.ts- Updated WASM interface definitionMakefile- Excluded scan/deparse WASM exportsREADME.md- Removed scan/deparse documentationRoot directory:
Makefile- New base Makefile for managing both packagesREADME.md- Copied from pg17-fullTesting
✅ Build Verification:
yarn buildmake install && make build✅ Functionality Verification:
Package Sizes
Preserved Requirements
Link to Devin run: https://app.devin.ai/sessions/38ffa883063641fd91ddd351006db24f
Requested by: Dan Lynch ([email protected])